You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2018/02/01 08:38:47 UTC

[GitHub] carbondata pull request #1772: [CARBONDATA-1995] Unify all writer steps and ...

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1772#discussion_r165287316
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/WriterProcessorStepImpl.java ---
    @@ -271,37 +262,18 @@ private CarbonRow convertRow(CarbonRow row) throws KeyGenException {
       }
     
       private void processBatch(CarbonRowBatch batch, CarbonFactHandler dataHandler, int iteratorIndex)
    -      throws CarbonDataLoadingException {
    -    try {
    -      while (batch.hasNext()) {
    -        CarbonRow row = batch.next();
    -        CarbonRow converted = convertRow(row);
    -        dataHandler.addDataToStore(converted);
    -        readCounter[iteratorIndex]++;
    +  {
    +    while (batch.hasNext()) {
    +      CarbonRow row;
    +      if (noSort) {
    --- End diff --
    
    move 'if' statement to the outside of 'while' loop


---