You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/23 00:45:33 UTC
[GitHub] [pulsar-site] urfreespace commented on a diff in pull request #169: Move config docs to /reference and improve docs gen scripts
urfreespace commented on code in PR #169:
URL: https://github.com/apache/pulsar-site/pull/169#discussion_r952038848
##########
site2/tools/build-site.sh:
##########
@@ -22,10 +22,12 @@ ROOT_DIR=$(git rev-parse --show-toplevel)
VERSION=$(${ROOT_DIR}/src/get-project-version.py)
NEXT=$1
-WEBSITE_DIR="website"
+WEBSITE_DIR=${ROOT_DIR}/site2/website
if [ -n "$NEXT" ]; then
- WEBSITE_DIR="website-"$NEXT
+ WEBSITE_DIR=${ROOT_DIR}/site2/website-$NEXT
fi
+TOOLS_DIR=${ROOT_DIR}/site2/tools
+GEN_SITE_DIR=$GEN_SITE_DIR
Review Comment:
why `GEN_SITE_DIR=$GEN_SITE_DIR`? Is this redundant? @SignorMercurio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org