You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2015/06/26 11:52:37 UTC
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
GitHub user rdowner opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/720
More fixes to release blockers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/incubator-brooklyn more-fixes-to-release-blockers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #720
----
commit ee2ff728c5d6fe8baea640e6204a2a1420085795
Author: Richard Downer <ri...@apache.org>
Date: 2015-06-25T15:39:49Z
Update pom.xml GnuPG settings
Sets the executable to gpg2, which is the usual name for the latest gpg
versions both on Linux and MacPorts.
Removes the set-empty-passphrase property. With gpg-agent correctly set
up, this means that the signing process will prompt for the GPG
passphrase when it is first needed, and cache the value for the
remainder of the build. This is more secure than writing down a GPG
passphrase either in settings.xml, pom.xml, or anywhere where it might
up in a command line history file.
Setting up gpg-agent in 10 seconds:
- Install a pinentry package. pinentry-mac from MacPorts;
pinentry-curses if you are remoting into a Linux machine
- Install gpg-agent if not already installed (on Ubuntu you'll need to
apt-get install gnupg-agent; but on MacPorts it's part of the gnupg2
package)
- Start the agent:
- gpg-agent --daemon --write-env-file "${HOME}/.gpg-agent-info"
- GPG_TTY=$(tty)
- export GPG_AGENT_INFO GPG_TTY
commit 80a51203ba6dfa47dfa62a1fd2d6d66775358944
Author: Richard Downer <ri...@apache.org>
Date: 2015-06-26T09:11:10Z
Mark an intermittently-failing test as WIP
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/720#issuecomment-115654796
I'm removing the test change from this PR, and will merge the `pom.xml` change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/720#discussion_r33344233
--- Diff: core/src/test/java/brooklyn/entity/rebind/RebindFeedTest.java ---
@@ -180,7 +180,7 @@ public void testSshFeedRegisteredInStartIsPersisted() throws Exception {
EntityTestUtils.assertAttributeEqualsEventually(newEntity, SENSOR_INT, (Integer)0);
}
- @Test
+ @Test(groups="WIP") // intermittent failures
--- End diff --
Makes sense for the release, but I'd prefer if we get it back post-release (so it can nag us until fixed :) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/720#discussion_r33346346
--- Diff: core/src/test/java/brooklyn/entity/rebind/RebindFeedTest.java ---
@@ -180,7 +180,7 @@ public void testSshFeedRegisteredInStartIsPersisted() throws Exception {
EntityTestUtils.assertAttributeEqualsEventually(newEntity, SENSOR_INT, (Integer)0);
}
- @Test
+ @Test(groups="WIP") // intermittent failures
--- End diff --
Can we mark it WIP only in the 0.7.0 release branch ?
Would mean splitting up this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/720#issuecomment-115654736
Relevant discussion from IRC channel, for the record:
```
[12:00:39] <alexheneveld> richardasf: do you have a jenkins failure for the RebindFeedTest failure you’ve marked WIP ?
[12:01:20] <alexheneveld> i haven’t noticed that one failing, and it’s a good test to have enabled
[12:02:06] <richardasf> No ... but I'm getting it pretty consistently 50% of the time on my release build env - an Ubuntu VirtualBox VM on my Mac. Error is that it expected 1 but got 6 or 8
[12:02:47] <richardasf> (it must be a rather unique environment for it to never show up on Jenkins)
[12:03:36] <alexheneveld> aha there has been one jenkins failure - https://mail-archives.apache.org/mod_mbox/incubator-brooklyn-dev/201502.mbox/%3C1038055890.9637.1424436655235.JavaMail.jenkins@crius%3E
[12:03:37] <svet> I also see it failing on a Ubuntu VM. Also consistently failing on the windows build
[12:03:44] <richardasf> https://builds.apache.org/job/incubator-brooklyn-master-windows/251/org.apache.brooklyn$brooklyn-core/#showFailuresLink
[12:04:07] <svet> (consistent as in 100%)
[12:04:10] <richardasf> Yep svet there it is failing on the Windows build - our canary-in-the-coalmine for tests on the edge :)
[12:04:33] <alexheneveld> odd. can we WIP that test on an 0.7.0 branch only?
[12:04:54] <richardasf> Yes we can do that
[12:05:20] <alexheneveld> thx - there’s a fair chance points to a rebind problem in those environments, rather than just a bad test
[12:06:57] <richardasf> Would you say that this test failure is important? It should be investigated further before releasing? Concerned that your statement suggests that Ubuntu VMs have a problem with rebind...
[12:22:40] <alexheneveld> no, shouldn’t block release — it’s a fringe issue, if persistence of feeds is on, you might get duplication of feeds.
[12:22:44] <alexheneveld> richardasf: ^^^
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: More fixes to release blockers
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/720#issuecomment-115631738
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---