You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/01 07:18:13 UTC

[GitHub] [tvm] slyubomirsky opened a new pull request #7554: [Relay][bugfix][error reporting] BiasAddRel does not check for a negative index being out of bounds

slyubomirsky opened a new pull request #7554:
URL: https://github.com/apache/tvm/pull/7554


   A follow-up to #7467 on `bias_add`, I realized the type relation wasn't bounds checking on the negative side. It's not a serious error, but it's good to have an informative error message for such cases. (I happened to be looking at that type relation because I was trying to formalize it in an ILP solver 😛)
   
   Please review @tkonolige @junrushao1994 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #7554: [Relay][bugfix][error reporting] BiasAddRel does not check for a negative index being out of bounds

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7554:
URL: https://github.com/apache/tvm/pull/7554


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7554: [Relay][bugfix][error reporting] BiasAddRel does not check for a negative index being out of bounds

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7554:
URL: https://github.com/apache/tvm/pull/7554#issuecomment-790116116


   Thanks you @slyubomirsky @tkonolige !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org