[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #246: fix parquet max_definition for non-null structs

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #246:
URL: https://github.com/apache/arrow-rs/pull/246#discussion_r624665033



##########
File path: parquet/src/arrow/levels.rs
##########
@@ -311,11 +333,20 @@ impl LevelInfo {
                 } else if self.is_list {
                     // second exception, always increment after a list
                     self.max_definition + 1
+                } else if is_parent_struct && !self.is_nullable {
+                    // if the parent is a non-null struct, don't increment

Review comment:
       I am trying to wrap my head around this comment: `self.is_nullable` is the nullability of the `parent` in this case?
   
   I would expect something like `is_parent_struct_null` computed from the nullability of the parent?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org