[GitHub] [eagle] grainier commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4

[GitBox <gi...@apache.org>]

grainier commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327474090
 
 

 ##########
 File path: eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
 ##########
 @@ -49,7 +49,7 @@ public void testRound2() {
         cal.set(Calendar.MINUTE, 0);
         cal.set(Calendar.SECOND, 0);
         cal.set(Calendar.MILLISECOND, 0);
-        Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//        Assert.assertEquals(tsInHour, cal.getTimeInMillis());
 
 Review comment:
   @haoch, sorry, it was a mistake. When I tried to build, this failed intermittently (even with the master), so I commented it out. Reverted with 1240042

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services