You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2023/06/01 20:34:53 UTC
[GitHub] [beam] tvalentyn commented on a diff in pull request #26971: remove 360M of installer files bloat.
tvalentyn commented on code in PR #26971:
URL: https://github.com/apache/beam/pull/26971#discussion_r1213652238
##########
sdks/python/container/Dockerfile:
##########
@@ -60,6 +60,7 @@ RUN mkdir -p /usr/local/gcloud && \
curl -s -O https://dl.google.com/dl/cloudsdk/release/google-cloud-sdk.tar.gz && \
tar -xf google-cloud-sdk.tar.gz && \
/usr/local/gcloud/google-cloud-sdk/install.sh && \
+ rm -rf /usr/local/gcloud/google-cloud-sdk/.install/.backup && \
rm google-cloud-sdk.tar.gz
Review Comment:
each RUN command adds a filesystem layer. rm needs to happen in the same layer that added the content, otherwise it will be just a filesystem metadata change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org