You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/04/05 14:51:22 UTC
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1851
[FLINK-3697] Properly access type information for nested POJO key selection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3697
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1851
----
commit 614e59f619ed64e20c7970640e8a22f7883a50af
Author: Robert Metzger <rm...@apache.org>
Date: 2016-04-05T12:48:40Z
[FLINK-3697] Properly access type information for nested POJO key selection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1851#issuecomment-206915028
I'll address Stephan's comment and merge the change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by RonCrocker <gi...@git.apache.org>.
Github user RonCrocker commented on a diff in the pull request:
https://github.com/apache/flink/pull/1851#discussion_r58564095
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/FieldAccessor.java ---
@@ -182,11 +182,14 @@ public R set(R record, F fieldValue) {
@SuppressWarnings("unchecked")
CompositeType<R> cType = (CompositeType<R>) type;
+ if(field.contains(".")) {
+ throw new IllegalArgumentException("The Pojo field accessor currently doesn't support nested POJOs");
--- End diff --
Note that the problem reported in [FLINK-3697](https://issues.apache.org/jira/browse/FLINK-3697) was not related to accessing a nested field.. Perhaps there should be a subsequent JIRA ticket to support nested POJO accessors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by RonCrocker <gi...@git.apache.org>.
Github user RonCrocker commented on the pull request:
https://github.com/apache/flink/pull/1851#issuecomment-205868281
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1851#discussion_r58564424
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/FieldAccessor.java ---
@@ -182,11 +182,14 @@ public R set(R record, F fieldValue) {
@SuppressWarnings("unchecked")
CompositeType<R> cType = (CompositeType<R>) type;
+ if(field.contains(".")) {
+ throw new IllegalArgumentException("The Pojo field accessor currently doesn't support nested POJOs");
--- End diff --
Thank you for reviewing my pull request. I've opened FLINK-3702 for that.
See also here: https://github.com/apache/flink/pull/1851/files#diff-e5e091a2c1e4bf850ef93e2010fe4c81R132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3697] Properly access type information ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1851#discussion_r58678493
--- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamPojoITCase.java ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api;
+
+import org.apache.flink.api.common.functions.FlatMapFunction;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.source.SourceFunction;
+import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase;
+import org.apache.flink.util.Collector;
+import org.junit.Test;
+
+/**
+ * Integration test for streaming programs using POJOs and key selectors
+ *
+ * See FLINK-3697
+ */
+public class DataStreamPojoITCase extends StreamingMultipleProgramsTestBase {
+
+ /**
+ * Test composite key on the Data POJO (with nested fields)
+ */
+ @Test
+ public void testCompositeKeyOnNestedPojo() throws Exception {
+ StreamExecutionEnvironment see = StreamExecutionEnvironment.getExecutionEnvironment();
+ see.getConfig().disableObjectReuse();
+ see.setParallelism(3);
+
+ DataStream<Data> dataStream = see.addSource(new DataGenerator());
--- End diff --
Why not use "fromCollection()" here and have a prepared list of sample data...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---