[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #310: [ISSUE-300] Make config type of RSS_CLIENT_TYPE as enum

[GitBox <gi...@apache.org>]

zuston commented on code in PR #310:
URL: https://github.com/apache/incubator-uniffle/pull/310#discussion_r1020707324


##########
server/src/main/java/org/apache/uniffle/server/RegisterHeartBeat.java:
##########
@@ -58,7 +58,7 @@ public RegisterHeartBeat(ShuffleServer shuffleServer) {
     this.heartBeatTimeout = conf.getLong(ShuffleServerConf.SERVER_HEARTBEAT_TIMEOUT);
     this.coordinatorQuorum = conf.getString(ShuffleServerConf.RSS_COORDINATOR_QUORUM);
     CoordinatorClientFactory factory =
-        new CoordinatorClientFactory(conf.getString(ShuffleServerConf.RSS_CLIENT_TYPE));
+        new CoordinatorClientFactory(conf.get(ShuffleServerConf.RSS_CLIENT_TYPE).name());

Review Comment:
   We could make all client type change from `string` to `enum` in anywhere 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org