FTPSERVER-122 Data races in FtpStatisticsImpl

[Yao Qi <qi...@gmail.com>]

Hello mina developers,

We are working on MutlThreaded Runtime Analysis Tool, MTRAT 
(http://www.alphaworks.ibm.com/tech/mtrat).  When we test MTRAT by
ftpserver, we found some data races in ftpserver and mina, and file a
bug report http://issues.apache.org/jira/browse/FTPSERVER-122

We didn't get any response from JIRA, so I post this bug report here for
an open discussion.  We still find some data races in other part of
mina, since we are still unfamiliar with mina code base, we did not file
bugs for them.  If you are interested in them, we could post them.

Any comments are appreciated.

Best Regards

-- 
Yao Qi <qiyaoltc AT gmail DOT com>    GNU/Linux Developer
http://duewayqi.googlepages.com/

If it's not in the computer, it doesn't exist.

Re: FTPSERVER-122 Data races in FtpStatisticsImpl

[Niklas Gustavsson <ni...@protocol7.com>]

Hi

On Tue, Apr 15, 2008 at 1:17 PM, Yao Qi <qi...@gmail.com> wrote:
>  We are working on MutlThreaded Runtime Analysis Tool, MTRAT
>  (http://www.alphaworks.ibm.com/tech/mtrat).  When we test MTRAT by
>  ftpserver, we found some data races in ftpserver and mina, and file a
>  bug report http://issues.apache.org/jira/browse/FTPSERVER-122
>
>  We didn't get any response from JIRA, so I post this bug report here for
>  an open discussion.  We still find some data races in other part of
>  mina, since we are still unfamiliar with mina code base, we did not file
>  bugs for them.  If you are interested in them, we could post them.

Sorry for not replying earlier and thanks a lot for the analysis! The
reason why I did not fix the race conditions already is that I'm
planning to bring FtpServers statistics handling more in line with
MINA. There is currently a thread ongoing where the API for this is
discussed so I'm holding of the changes until that is cleared:
http://www.nabble.com/IoService-API-growth-td16164276.html

Anyways, I would much appreciate further analysis on the source code,
especially after the statistics implementation is updated.

/niklas