[GitHub] [solr] HoustonPutman commented on pull request #892: SOLR-16232: Fix EnvVar usage in bin/solr

[GitBox <gi...@apache.org>]

HoustonPutman commented on PR #892:
URL: https://github.com/apache/solr/pull/892#issuecomment-1249686311

   > For some of them, like export and package, I thought that we explicitly did want word splitting?
   
   @madrob So we do want word splitting, but by what the user split by in the first place. That's what `"$var[@]"` does, it basically just puts quotes around the original arguments provided by the user. Using just `$var[@]` will re-split, even if the user has provided an argument like `-query "*:* - name:Mike"`, that will be resplit to `"-query" "*:*" "-" "name:Mike"`, which is definitely not what we want
   
   I have added a simple test for export that shows this. Not sure it's completely necessary for package, but I guess I could if we really need to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org