You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/05 09:00:13 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
godfreyhe opened a new pull request #14315:
URL: https://github.com/apache/flink/pull/14315
## What is the purpose of the change
*As discussed in [FLINK-20478](https://issues.apache.org/jira/browse/FLINK-20478), this pr aims to adjust the explain result as following:
So I suggest to make the following adjustments:
1. Keep "Abstract Syntax Tree" as it, which represents the original (un-optimized) RelNode graph converted from SqlNode.
2. Rename "Optimized Logical Plan" to "Optimized Physical Plan", which represents the optimized physical RelNode graph composed of FlinkPhysicalRel.
3.Replace "Physical Execution Plan" with "Optimized Execution Plan", which represents the optimized ExecNode graph. Because "Physical Execution Plan" is not very useful to users.*
## Brief change log
*(for example:)*
- *Adjust the explain result for blink planner*
- *[hotfix] BatchExecRank#explainTerms should use `RelWriter#input` instead of `RelWriter#item` for input rel*
- *ExecNodePlanDumper only displays the attributes of ExecNode*
## Verifying this change
This change is already covered by existing tests, such as *ExplainTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c89b7c0522e126bb172acaef9d182d602a4a7d34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557)
* 7d81f10ae1ee99ae852e4333e9ac766c44f563cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d81f10ae1ee99ae852e4333e9ac766c44f563cf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539820000
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodePlanDumper.java
##########
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.table.planner.plan.nodes.calcite.LegacySink;
+import org.apache.flink.table.planner.plan.nodes.calcite.Sink;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitor;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitorImpl;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An utility class for converting an exec node plan to a string as a tree style.
+ */
+public class ExecNodePlanDumper {
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @return explain plan of ExecNode
+ *
+ * <p> The following tree of {@link ExecNode}
Review comment:
if there is only one sink (root) node, it's a rooted tree, see https://en.wikipedia.org/wiki/Tree_(graph_theory)#Rooted_tree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
}, {
"hash" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764",
"triggerID" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"triggerType" : "PUSH"
}, {
"hash" : "641ede9d043a115cfb2613aae136dac460cce1e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "641ede9d043a115cfb2613aae136dac460cce1e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
* f11937f7d55cebf72abaec9c64c4561e32be2fa9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764)
* 641ede9d043a115cfb2613aae136dac460cce1e0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739149629
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8528efbd9f9a7b9906a53124640a28602f70321f (Sat Dec 05 09:01:54 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20478).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539817633
##########
File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/ValuesTest.xml
##########
@@ -34,9 +34,9 @@ LogicalProject(a=[$0], b=[$1]), rowType=[RecordType(INTEGER a, DECIMAL(20, 1) b)
<![CDATA[
Union(all=[true], union=[EXPR$0, EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
:- Calc(select=[1 AS EXPR$0, 2.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
-: +- Values(tuples=[[{ 0 }]], values=[ZERO], reuse_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+: +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
+- Calc(select=[3 AS EXPR$0, 4.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
- +- Reused(reference_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+ +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
Review comment:
because the case tests the rel plan with row type, only exec plan will reuse the sub-plan, not rel plan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d81f10ae1ee99ae852e4333e9ac766c44f563cf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572)
* 7890576ec8c791313d5a309a3488b1de846e2e47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
}, {
"hash" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764",
"triggerID" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
* f11937f7d55cebf72abaec9c64c4561e32be2fa9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c89b7c0522e126bb172acaef9d182d602a4a7d34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712)
* a1e0179a7a99f8f4783954d142b8135f810dfd71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
}, {
"hash" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
* f11937f7d55cebf72abaec9c64c4561e32be2fa9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557)
* 7d81f10ae1ee99ae852e4333e9ac766c44f563cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
V1ncentzzZ commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r538954554
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/nodes/exec/TestingBatchExecNode.scala
##########
@@ -23,6 +23,7 @@ import org.apache.flink.table.api.TableConfig
import org.apache.flink.table.planner.calcite.{FlinkContextImpl, FlinkRelOptClusterFactory, FlinkRexBuilder, FlinkTypeFactory, FlinkTypeSystem}
import org.apache.flink.table.planner.delegation.BatchPlanner
import org.apache.flink.table.planner.plan.nodes.physical.batch.BatchPhysicalRel
+import org.apache.flink.table.types.logical.RowType
Review comment:
Maybe it's useless import?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a3f61482d6083556f5304a670939332f676ee879 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539834621
##########
File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/ValuesTest.xml
##########
@@ -34,9 +34,9 @@ LogicalProject(a=[$0], b=[$1]), rowType=[RecordType(INTEGER a, DECIMAL(20, 1) b)
<![CDATA[
Union(all=[true], union=[EXPR$0, EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
:- Calc(select=[1 AS EXPR$0, 2.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
-: +- Values(tuples=[[{ 0 }]], values=[ZERO], reuse_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+: +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
+- Calc(select=[3 AS EXPR$0, 4.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
- +- Reused(reference_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+ +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
Review comment:
I had created a [JIRA](https://issues.apache.org/jira/browse/FLINK-20509) to refactor the test case, after that your concern will be dispelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d244b5a760a84cc019788bc8c4ce84784152d26f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543)
* a3f61482d6083556f5304a670939332f676ee879 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7890576ec8c791313d5a309a3488b1de846e2e47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
}, {
"hash" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764",
"triggerID" : "f11937f7d55cebf72abaec9c64c4561e32be2fa9",
"triggerType" : "PUSH"
}, {
"hash" : "641ede9d043a115cfb2613aae136dac460cce1e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10771",
"triggerID" : "641ede9d043a115cfb2613aae136dac460cce1e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
* f11937f7d55cebf72abaec9c64c4561e32be2fa9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10764)
* 641ede9d043a115cfb2613aae136dac460cce1e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10771)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d244b5a760a84cc019788bc8c4ce84784152d26f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543)
* a3f61482d6083556f5304a670939332f676ee879 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539814663
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/FlinkRelNode.scala
##########
@@ -89,19 +89,31 @@ trait FlinkRelNode extends RelNode {
val ops = c.getOperands.map(
getExpressionString(_, inFields, localExprsTable, expressionFormat))
c.getOperator match {
- case _ : SqlAsOperator => ops.head
+ case _: SqlAsOperator => ops.head
case _ =>
- expressionFormat match {
- case ExpressionFormat.Infix if ops.size() == 1 =>
- val operand = ops.head
- c.getKind match {
- case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN | IS_NULL |
- IS_NOT_NULL => s"$operand $op"
- case _ => s"$op($operand)"
- }
- case ExpressionFormat.Infix => s"(${ops.mkString(s" $op ")})"
- case ExpressionFormat.PostFix => s"(${ops.mkString(", ")})$op"
- case ExpressionFormat.Prefix => s"$op(${ops.mkString(", ")})"
+ if (ops.size() == 1) {
+ val operand = ops.head
+ c.getKind match {
+ case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN
+ | IS_NULL | IS_NOT_NULL => s"$operand $op"
+ case _ => s"$op($operand)"
+ }
+ } else {
+ c.getKind match {
+ case TIMES | DIVIDE | PLUS | MINUS
Review comment:
The udfs should be prefix format. `my_add(a, b)` for prefix format is easier readable than `a my_add b` for infix format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a3f61482d6083556f5304a670939332f676ee879 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552)
* 5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7890576ec8c791313d5a309a3488b1de846e2e47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701)
* c89b7c0522e126bb172acaef9d182d602a4a7d34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe merged pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #14315:
URL: https://github.com/apache/flink/pull/14315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
}, {
"hash" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712",
"triggerID" : "c89b7c0522e126bb172acaef9d182d602a4a7d34",
"triggerType" : "PUSH"
}, {
"hash" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735",
"triggerID" : "a1e0179a7a99f8f4783954d142b8135f810dfd71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c89b7c0522e126bb172acaef9d182d602a4a7d34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10712)
* a1e0179a7a99f8f4783954d142b8135f810dfd71 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a3f61482d6083556f5304a670939332f676ee879 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552)
* 5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539813438
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodePlanDumper.java
##########
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.table.planner.plan.nodes.calcite.LegacySink;
+import org.apache.flink.table.planner.plan.nodes.calcite.Sink;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitor;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitorImpl;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An utility class for converting an exec node plan to a string as a tree style.
+ */
+public class ExecNodePlanDumper {
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @return explain plan of ExecNode
+ *
+ * <p> The following tree of {@link ExecNode}
+ * <pre>{@code
+ * Sink
+ * |
+ * Join
+ * / \
+ * Filter1 Filter2
+ * \ /
+ * Project1
+ * |
+ * Scan
+ * }</pre>
+ *
+ * would be converted to the tree style as following:
+ * <pre>{@code
+ * Sink
+ * +- Join
+ * :- Filter1
+ * : +- Project1(reuse_id=[1])
+ * : +- Scan
+ * +- Filter2
+ * +- Reused(reference_id=[1])
+ * }
+ * }</pre>
+ */
+ public static String treeToString(ExecNode<?> node) {
+ return treeToString(node, new ArrayList<>(), false);
+ }
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @param borders node sets that stop visit when meet them
+ * @param includingBorders Whether print the border nodes
+ * @return the plan of ExecNode
+ */
+ public static String treeToString(ExecNode<?> node, List<ExecNode<?>> borders, boolean includingBorders) {
+ checkNotNull(node, "node should not be null.");
+ // convert to mutable list
+ List<ExecNode<?>> borderList = new ArrayList<>(checkNotNull(borders, "borders should not be null."));
+ TreeReuseInfo reuseInfo = new TreeReuseInfo(node, borderList);
+ return doConvertTreeToString(node, reuseInfo, true, borderList, includingBorders);
+ }
+
+ /**
+ * Converts an {@link ExecNode} DAG to a string as a tree style.
+ *
+ * @param nodes the ExecNodes to convert
+ * @return the plan of ExecNode
+ *
+ * <p> The following DAG of {@link ExecNode}
+ * <pre>{@code
+ * Sink1 Sink2
+ * | |
+ * Filter3 Filter4
+ * \ /
+ * Join
+ * / \
+ * Filter1 Filter2
+ * \ /
+ * Project1
+ * |
+ * Scan
+ * }</pre>
+ *
+ * would be converted to the tree style as following:
+ * <pre>{@code
Review comment:
how to display the reused (common) plan ? If the result of the example just contains two trees, each tree will display all nodes from sink to source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539785239
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodePlanDumper.java
##########
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.table.planner.plan.nodes.calcite.LegacySink;
+import org.apache.flink.table.planner.plan.nodes.calcite.Sink;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitor;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitorImpl;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An utility class for converting an exec node plan to a string as a tree style.
+ */
+public class ExecNodePlanDumper {
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @return explain plan of ExecNode
+ *
+ * <p> The following tree of {@link ExecNode}
Review comment:
I think it is a dag not tree?
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/FlinkRelNode.scala
##########
@@ -89,19 +89,31 @@ trait FlinkRelNode extends RelNode {
val ops = c.getOperands.map(
getExpressionString(_, inFields, localExprsTable, expressionFormat))
c.getOperator match {
- case _ : SqlAsOperator => ops.head
+ case _: SqlAsOperator => ops.head
case _ =>
- expressionFormat match {
- case ExpressionFormat.Infix if ops.size() == 1 =>
- val operand = ops.head
- c.getKind match {
- case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN | IS_NULL |
- IS_NOT_NULL => s"$operand $op"
- case _ => s"$op($operand)"
- }
- case ExpressionFormat.Infix => s"(${ops.mkString(s" $op ")})"
- case ExpressionFormat.PostFix => s"(${ops.mkString(", ")})$op"
- case ExpressionFormat.Prefix => s"$op(${ops.mkString(", ")})"
+ if (ops.size() == 1) {
+ val operand = ops.head
+ c.getKind match {
+ case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN
+ | IS_NULL | IS_NOT_NULL => s"$operand $op"
+ case _ => s"$op($operand)"
+ }
+ } else {
+ c.getKind match {
+ case TIMES | DIVIDE | PLUS | MINUS
Review comment:
what is the purpose to change this?
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/utils/ExecNodePlanDumper.java
##########
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.utils;
+
+import org.apache.flink.table.planner.plan.nodes.calcite.LegacySink;
+import org.apache.flink.table.planner.plan.nodes.calcite.Sink;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitor;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeVisitorImpl;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.util.Preconditions;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.IdentityHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An utility class for converting an exec node plan to a string as a tree style.
+ */
+public class ExecNodePlanDumper {
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @return explain plan of ExecNode
+ *
+ * <p> The following tree of {@link ExecNode}
+ * <pre>{@code
+ * Sink
+ * |
+ * Join
+ * / \
+ * Filter1 Filter2
+ * \ /
+ * Project1
+ * |
+ * Scan
+ * }</pre>
+ *
+ * would be converted to the tree style as following:
+ * <pre>{@code
+ * Sink
+ * +- Join
+ * :- Filter1
+ * : +- Project1(reuse_id=[1])
+ * : +- Scan
+ * +- Filter2
+ * +- Reused(reference_id=[1])
+ * }
+ * }</pre>
+ */
+ public static String treeToString(ExecNode<?> node) {
+ return treeToString(node, new ArrayList<>(), false);
+ }
+
+ /**
+ * Converts an {@link ExecNode} tree to a string as a tree style.
+ *
+ * @param node the ExecNode to convert
+ * @param borders node sets that stop visit when meet them
+ * @param includingBorders Whether print the border nodes
+ * @return the plan of ExecNode
+ */
+ public static String treeToString(ExecNode<?> node, List<ExecNode<?>> borders, boolean includingBorders) {
+ checkNotNull(node, "node should not be null.");
+ // convert to mutable list
+ List<ExecNode<?>> borderList = new ArrayList<>(checkNotNull(borders, "borders should not be null."));
+ TreeReuseInfo reuseInfo = new TreeReuseInfo(node, borderList);
+ return doConvertTreeToString(node, reuseInfo, true, borderList, includingBorders);
+ }
+
+ /**
+ * Converts an {@link ExecNode} DAG to a string as a tree style.
+ *
+ * @param nodes the ExecNodes to convert
+ * @return the plan of ExecNode
+ *
+ * <p> The following DAG of {@link ExecNode}
+ * <pre>{@code
+ * Sink1 Sink2
+ * | |
+ * Filter3 Filter4
+ * \ /
+ * Join
+ * / \
+ * Filter1 Filter2
+ * \ /
+ * Project1
+ * |
+ * Scan
+ * }</pre>
+ *
+ * would be converted to the tree style as following:
+ * <pre>{@code
Review comment:
just wonder that why the result doesn't contain 2 tree starting from sink but three trees? IMO, treeToString and dagToString can be unified and it maybe easier to understand for user if the plan starts from sink.
##########
File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/ValuesTest.xml
##########
@@ -34,9 +34,9 @@ LogicalProject(a=[$0], b=[$1]), rowType=[RecordType(INTEGER a, DECIMAL(20, 1) b)
<![CDATA[
Union(all=[true], union=[EXPR$0, EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
:- Calc(select=[1 AS EXPR$0, 2.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
-: +- Values(tuples=[[{ 0 }]], values=[ZERO], reuse_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+: +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
+- Calc(select=[3 AS EXPR$0, 4.0:DECIMAL(20, 1) AS EXPR$1]), rowType=[RecordType(INTEGER EXPR$0, DECIMAL(20, 1) EXPR$1)]
- +- Reused(reference_id=[1]), rowType=[RecordType(INTEGER ZERO)]
+ +- Values(tuples=[[{ 0 }]], values=[ZERO]), rowType=[RecordType(INTEGER ZERO)]
Review comment:
why source not reused?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d244b5a760a84cc019788bc8c4ce84784152d26f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d244b5a760a84cc019788bc8c4ce84784152d26f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14315:
URL: https://github.com/apache/flink/pull/14315#discussion_r539792067
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/FlinkRelNode.scala
##########
@@ -89,19 +89,31 @@ trait FlinkRelNode extends RelNode {
val ops = c.getOperands.map(
getExpressionString(_, inFields, localExprsTable, expressionFormat))
c.getOperator match {
- case _ : SqlAsOperator => ops.head
+ case _: SqlAsOperator => ops.head
case _ =>
- expressionFormat match {
- case ExpressionFormat.Infix if ops.size() == 1 =>
- val operand = ops.head
- c.getKind match {
- case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN | IS_NULL |
- IS_NOT_NULL => s"$operand $op"
- case _ => s"$op($operand)"
- }
- case ExpressionFormat.Infix => s"(${ops.mkString(s" $op ")})"
- case ExpressionFormat.PostFix => s"(${ops.mkString(", ")})$op"
- case ExpressionFormat.Prefix => s"$op(${ops.mkString(", ")})"
+ if (ops.size() == 1) {
+ val operand = ops.head
+ c.getKind match {
+ case IS_FALSE | IS_NOT_FALSE | IS_TRUE | IS_NOT_TRUE | IS_UNKNOWN
+ | IS_NULL | IS_NOT_NULL => s"$operand $op"
+ case _ => s"$op($operand)"
+ }
+ } else {
+ c.getKind match {
+ case TIMES | DIVIDE | PLUS | MINUS
Review comment:
what is the purpose to change this? is there any bad case to use Infix in all expresssion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10543",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
}, {
"hash" : "a3f61482d6083556f5304a670939332f676ee879",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10552",
"triggerID" : "a3f61482d6083556f5304a670939332f676ee879",
"triggerType" : "PUSH"
}, {
"hash" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10557",
"triggerID" : "5d0686ca5fcf8ac45b5fcf7e884864ffe3c5ab7e",
"triggerType" : "PUSH"
}, {
"hash" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572",
"triggerID" : "7d81f10ae1ee99ae852e4333e9ac766c44f563cf",
"triggerType" : "PUSH"
}, {
"hash" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701",
"triggerID" : "7890576ec8c791313d5a309a3488b1de846e2e47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d81f10ae1ee99ae852e4333e9ac766c44f563cf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10572)
* 7890576ec8c791313d5a309a3488b1de846e2e47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10701)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14315: [FLINK-20478][table-planner-blink] Adjust the explain result for blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14315:
URL: https://github.com/apache/flink/pull/14315#issuecomment-739151875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d244b5a760a84cc019788bc8c4ce84784152d26f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d244b5a760a84cc019788bc8c4ce84784152d26f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org