[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #621: [#378] feat: introduce storage manager selector

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #621:
URL: https://github.com/apache/incubator-uniffle/pull/621#discussion_r1117899965


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -263,6 +264,15 @@ public class ShuffleServerConf extends RssBaseConf {
       .defaultValue(64L * 1024L * 1024L)
       .withDescription("For multistorage, the event size exceed this value, flush data  to cold storage");
 
+  public static final ConfigOption<StorageManagerSelector.ColdStoragePreferredFactor>
+      MULTISTORAGE_SELECTOR_COLD_STORAGE_PREFER = ConfigOptions
+      .key("rss.server.multistorage.cold.storage.preferred.factor")

Review Comment:
   Could you give this config option a better name? It is more like a strategy in our system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org