You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiacai2050 (via GitHub)" <gi...@apache.org> on 2023/02/01 14:58:40 UTC

[GitHub] [arrow-datafusion] jiacai2050 commented on a diff in pull request #5124: Add option to control whether to normalize ident

jiacai2050 commented on code in PR #5124:
URL: https://github.com/apache/arrow-datafusion/pull/5124#discussion_r1093340097


##########
datafusion/sql/src/relation/mod.rs:
##########
@@ -33,7 +33,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         let (plan, alias) = match relation {
             TableFactor::Table { name, alias, .. } => {
                 // normalize name and alias
-                let table_ref = object_name_to_table_reference(name)?;
+                let table_ref = object_name_to_table_reference(
+                    name,
+                    self.options.enable_ident_normalization,
+                )?;

Review Comment:
   Make sense, I can fix this in following PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org