[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1368: Refactor to remove event dispatcher completely

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #1368:
URL: https://github.com/apache/dubbo-go/pull/1368#discussion_r715325770



##########
File path: registry/servicediscovery/service_discovery_registry.go
##########
@@ -352,5 +344,26 @@ func tryInitMetadataService(url *common.URL) {
 	if err != nil {
 		logger.Errorf("could not export the metadata service", err)
 	}
-	extension.GetGlobalDispatcher().Dispatch(event.NewServiceConfigExportedEvent(expt.(*configurable.MetadataServiceExporter).ServiceConfig))
+
+	// report interface-app mapping
+	err = publishMapping(expt.(*configurable.MetadataServiceExporter).ServiceConfig)
+	if err != nil {
+		logger.Errorf("Publish interface-application mapping failed", err)

Review comment:
       I have fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org