You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/18 15:26:25 UTC

[GitHub] brodybits commented on issue #162: [CB-14156] Remove browserify

brodybits commented on issue #162: [CB-14156] Remove browserify
URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422439253
 
 
   > @brodybits Could you explain what you mean by "known to fail `npm test`"? The CI tests all passed.
   
   I think (recall) that when I raised this PR it would not pass `npm test`. 
   
   > I also removed the _WIP_ in the title, as this is now finished IMHO.
   
   I was kinda surprised that you did not remove _NOT TESTED_ from the title. I just removed these words in good faith that you would have actually tested the changes after rebasing and before approving.
   
   I just marked 5.0.0-dev (#170), would like to do one more rebase before merging. I would favor merging this in a merge commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org