You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 16:35:35 UTC

[GitHub] [airflow] sarahamilton opened a new issue #14077: GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly

sarahamilton opened a new issue #14077:
URL: https://github.com/apache/airflow/issues/14077


   **Apache Airflow version**: 1.10.12
   
   **Environment**:  Google Cloud Composer 1.13.3
   
   - **Cloud provider or hardware configuration**:
   - Google Cloud Composer
   
   **What happened**:
   The GoogleDisplayVideo360Hook.download_media hook tries to download media using the "resource_name" argument. However, [per the API spec](https://developers.google.com/display-video/api/reference/rest/v1/media/download) it should pass "resourceName" Thus, it breaks every time and can never download media.
   
   Error: `ERROR - Got an unexpected keyword argument "resource_name"`
   
   **What you expected to happen**: The hook should pass in the correct resourceName and then download the media file.
   
   
   **How to reproduce it**: Run any workflow that tries to download any DV360 media.
   
   **Anything else we need to know**: I have written a patch that fixes the issue and will submit it shortly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #14077: GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #14077:
URL: https://github.com/apache/airflow/issues/14077


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mishc9 edited a comment on issue #14077: GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly

Posted by GitBox <gi...@apache.org>.
mishc9 edited a comment on issue #14077:
URL: https://github.com/apache/airflow/issues/14077#issuecomment-1001782594


   I've opened new PR based on this closed [pull request](https://github.com/apache/airflow/pull/14078) that could resolve this issue. Fixed tests that failed in original PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mishc9 commented on issue #14077: GoogleDisplayVideo360Hook.download_media does not pass the resourceName correctly

Posted by GitBox <gi...@apache.org>.
mishc9 commented on issue #14077:
URL: https://github.com/apache/airflow/issues/14077#issuecomment-1001782594


   I've opened new PR based on this closed [pull request](https://github.com/apache/airflow/pull/20528) that could resolve this issue. Fixed tests that failed in original PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org