You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andrew Phillips (JIRA)" <ji...@codehaus.org> on 2011/05/22 16:57:22 UTC
[jira] Created: (WAGON-328) Allow putDirectory to continue even if
an individual file transfer fails
Allow putDirectory to continue even if an individual file transfer fails
------------------------------------------------------------------------
Key: WAGON-328
URL: http://jira.codehaus.org/browse/WAGON-328
Project: Maven Wagon
Issue Type: Improvement
Components: wagon-webdav
Affects Versions: 1.0-beta-8
Reporter: Andrew Phillips
The current WebDAV wagon implements putDirectory as a recursive sequence of individual put commands for the individual files. This means that failure of an individual put will abort the entire putDirectory.
This, of course, is generally correct and desired behaviour. However, in a few cases it may not be critical that all files in a directory are correctly uploaded. The use case in mind here is uploading Maven sites to not 100% reliable DAV resources, e.g. Google Code (see also [WAGON-319]).
The request would be thus to add a "continueOnFailure" option (or similar) which would not throw a TransferFailureException if put fails, but instead log a warning or similar. This option would be false by default.
Admittedly, the better/"correct" place to address this issue would be in the code that *calls* the wagon (in the case of this example, in the Maven Site plugin), because it can make the context-specific decision of whether to be lenient with errors or not.
However, there is no "putDirectoryLeniently" wagon method that the parent can call, and this use case does not seem significant enough to merit changing the wagon interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WAGON-328) Allow putDirectory to continue even if
an individual file transfer fails
Posted by "Andrew Phillips (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Phillips updated WAGON-328:
----------------------------------
Attachment: WAGON-328-patch.diff
> Allow putDirectory to continue even if an individual file transfer fails
> ------------------------------------------------------------------------
>
> Key: WAGON-328
> URL: http://jira.codehaus.org/browse/WAGON-328
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-webdav
> Affects Versions: 1.0-beta-8
> Reporter: Andrew Phillips
> Attachments: WAGON-328-patch.diff
>
>
> The current WebDAV wagon implements putDirectory as a recursive sequence of individual put commands for the individual files. This means that failure of an individual put will abort the entire putDirectory.
> This, of course, is generally correct and desired behaviour. However, in a few cases it may not be critical that all files in a directory are correctly uploaded. The use case in mind here is uploading Maven sites to not 100% reliable DAV resources, e.g. Google Code (see also [WAGON-319]).
> The request would be thus to add a "continueOnFailure" option (or similar) which would not throw a TransferFailureException if put fails, but instead log a warning or similar. This option would be false by default.
> Admittedly, the better/"correct" place to address this issue would be in the code that *calls* the wagon (in the case of this example, in the Maven Site plugin), because it can make the context-specific decision of whether to be lenient with errors or not.
> However, there is no "putDirectoryLeniently" wagon method that the parent can call, and this use case does not seem significant enough to merit changing the wagon interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (WAGON-328) Allow putDirectory to continue even if
an individual file transfer fails
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed WAGON-328.
------------------------------
Resolution: Fixed
Fix Version/s: 2.0
Assignee: Olivier Lamy
fixed rev 1174134
Thanks
> Allow putDirectory to continue even if an individual file transfer fails
> ------------------------------------------------------------------------
>
> Key: WAGON-328
> URL: https://jira.codehaus.org/browse/WAGON-328
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-webdav
> Affects Versions: 1.0
> Reporter: Andrew Phillips
> Assignee: Olivier Lamy
> Fix For: 2.0
>
> Attachments: WAGON-328-patch.diff
>
>
> The current WebDAV wagon implements putDirectory as a recursive sequence of individual put commands for the individual files. This means that failure of an individual put will abort the entire putDirectory.
> This, of course, is generally correct and desired behaviour. However, in a few cases it may not be critical that all files in a directory are correctly uploaded. The use case in mind here is uploading Maven sites to not 100% reliable DAV resources, e.g. Google Code (see also [WAGON-319]).
> The request would be thus to add a "continueOnFailure" option (or similar) which would not throw a TransferFailureException if put fails, but instead log a warning or similar. This option would be false by default.
> Admittedly, the better/"correct" place to address this issue would be in the code that *calls* the wagon (in the case of this example, in the Maven Site plugin), because it can make the context-specific decision of whether to be lenient with errors or not.
> However, there is no "putDirectoryLeniently" wagon method that the parent can call, and this use case does not seem significant enough to merit changing the wagon interface.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-328) Allow putDirectory to continue even
if an individual file transfer fails
Posted by "Andrew Phillips (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268123#action_268123 ]
Andrew Phillips commented on WAGON-328:
---------------------------------------
Version with patch applied available for testing at https://github.com/demobox/wagon-webdav-jackrabbit/tree/1.0-beta-8-WAGON-319.328
> Allow putDirectory to continue even if an individual file transfer fails
> ------------------------------------------------------------------------
>
> Key: WAGON-328
> URL: http://jira.codehaus.org/browse/WAGON-328
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-webdav
> Affects Versions: 1.0-beta-8
> Reporter: Andrew Phillips
> Attachments: WAGON-328-patch.diff
>
>
> The current WebDAV wagon implements putDirectory as a recursive sequence of individual put commands for the individual files. This means that failure of an individual put will abort the entire putDirectory.
> This, of course, is generally correct and desired behaviour. However, in a few cases it may not be critical that all files in a directory are correctly uploaded. The use case in mind here is uploading Maven sites to not 100% reliable DAV resources, e.g. Google Code (see also [WAGON-319]).
> The request would be thus to add a "continueOnFailure" option (or similar) which would not throw a TransferFailureException if put fails, but instead log a warning or similar. This option would be false by default.
> Admittedly, the better/"correct" place to address this issue would be in the code that *calls* the wagon (in the case of this example, in the Maven Site plugin), because it can make the context-specific decision of whether to be lenient with errors or not.
> However, there is no "putDirectoryLeniently" wagon method that the parent can call, and this use case does not seem significant enough to merit changing the wagon interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira