You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/08/30 08:35:42 UTC

[GitHub] [camel-quarkus] JiriOndrusek commented on issue #5028: Micrometer: Router policy should be disabled by default (to be consistent with Camel)

JiriOndrusek commented on issue #5028:
URL: https://github.com/apache/camel-quarkus/issues/5028#issuecomment-1698734443

   @zhfeng thanks for noticing the issue! 
   
   TBH I still think that my previous comment is right.
   Let me explain:  
   
   - Micrometer Router policy **in Camel** is disabled by default, see [documentation](https://camel.apache.org/components/3.20.x/micrometer-component.html#_using_micrometer_route_policy_factory), following code has to be used to enable policy: `context.addRoutePolicyFactory(new MicrometerRoutePolicyFactory());`.
   - Micrometer Router policy **in CSB** is enabled by default, see [documentation](https://camel.apache.org/components/3.20.x/micrometer-component.html#_sb_option_camel_metrics_enable-route-policy)
   - Micrometer Router policy **in CQ** is currently enabled by default, but I think, that it should be disabled (and therefore disabled with plain Camel)
   
   I'll prepare a PR which changes this behavior as I suggested above. Therefore we should keep this issue opened.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org