[GitHub] [hudi] vinothchandar commented on a change in pull request #2085: [HUDI-1209] Properties File must be optional when running deltastreamer

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #2085:
URL: https://github.com/apache/hudi/pull/2085#discussion_r493940237



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -112,9 +112,14 @@ public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs, Con
   public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs, Configuration conf,
                              TypedProperties props) throws IOException {
     // Resolving the properties first in a consistent way
-    this.properties = props != null ? props : UtilHelpers.readConfig(
-        FSUtils.getFs(cfg.propsFilePath, jssc.hadoopConfiguration()),
-        new Path(cfg.propsFilePath), cfg.configs).getConfig();
+    if (props != null) {
+      this.properties = props;
+    } else {

Review comment:
       can this be written more readable? using if-elseif blocks? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org