[GitHub] [flink] matriv commented on pull request #17396: [FLINK-24393][test] Add CAST tests for type combinations

[GitBox <gi...@apache.org>]

matriv commented on pull request #17396:
URL: https://github.com/apache/flink/pull/17396#issuecomment-933357929


   @slinkydeveloper 
   
   > > * I see there are some failing "casts" returning null. Perhaps, given the [TRY_CAST issue](https://issues.apache.org/jira/browse/FLINK-24385), would it be better for the `CastTestSpecBuilder` to have a method like `fails` or something like that? Now such a method should just wrap the `resultsIn(null)` invocation, but when the TRY_CAST issue is tackled it can be modified to assert if an exception is thrown when executing the query. So we can just reuse these test cases for TRY_CAST as well
   > 
   > Good idea, I'll try to "prepare the ground" for the upcoming changes and tests, thx!
   
   I'd actually postpone this work until the TRY_CAST. If we introduce a `fails()` method then this method should create `ErrorTestItem`s which will have the corresponding expected error msg, something that cannot be used at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org