You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/10/25 02:15:10 UTC

[PR] [CELEBORN-1084][FOLLOWUP][0.3] Import `mock` method to restore CI [incubator-celeborn]

cfmcgrady opened a new pull request, #2040:
URL: https://github.com/apache/incubator-celeborn/pull/2040

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   As title
   
   ### Why are the changes needed?
   
   The branch-0.3 CI process encountered a compiler error as follows:
   
   ```
   Error:  /home/runner/work/incubator-celeborn/incubator-celeborn/worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/FileWriterSuiteJ.java:140:65:  error: cannot find symbol
   Warning:  javac exited with exit code 1
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1084][FOLLOWUP][0.3] Import `mock` method to recover CI [incubator-celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2040:
URL: https://github.com/apache/incubator-celeborn/pull/2040#issuecomment-1778413392

   thanks, merged to branch-0.3(v0.3.2)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1084][FOLLOWUP][0.3] Import `mock` method to recover CI [incubator-celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2040: [CELEBORN-1084][FOLLOWUP][0.3] Import `mock` method to recover CI
URL: https://github.com/apache/incubator-celeborn/pull/2040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1084][FOLLOWUP][0.3] Import `mock` method to restore CI [incubator-celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2040:
URL: https://github.com/apache/incubator-celeborn/pull/2040#issuecomment-1778395270

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2040?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2040](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2040?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1745f05) into [branch-0.3](https://app.codecov.io/gh/apache/incubator-celeborn/commit/ed94d8476645d837ebaae6cbf200d0f76bc0880a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ed94d84) will **increase** coverage by `0.02%`.
   > Report is 1 commits behind head on branch-0.3.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff               @@
   ##           branch-0.3    #2040      +/-   ##
   ==============================================
   + Coverage       46.27%   46.29%   +0.02%     
   ==============================================
     Files             165      165              
     Lines           10431    10431              
     Branches          970      970              
   ==============================================
   + Hits             4826     4828       +2     
   + Misses           5286     5285       -1     
   + Partials          319      318       -1     
   ```
   
   
   [see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2040/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org