You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/19 11:27:50 UTC
[GitHub] [incubator-pegasus] totalo opened a new pull request, #1130: refactor(java-client):Optimize the code style of `PegasusScanner`
totalo opened a new pull request, #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130
#887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] totalo commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
totalo commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951180808
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
I think it's because #1096 was removed, but I didn't merge master, it used to run d
I think it's because #1096 was removed, but I didn't merge the master, I ran the previous complete code so that my pr could pass, and then the master didn't run ci again after the pr was merged, so I didn't find this problem.
Maybe we need to run ci after merging to master.
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
I think it's because #1096 was removed, but I didn't merge the master, I ran the previous complete code so that my pr could pass, and then the master didn't run ci again after the pr was merged, so I didn't find this problem.
Maybe we need to run ci after merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951057447
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
`authProtocol` is not existed, I'm confused why ci can pass in https://github.com/apache/incubator-pegasus/pull/1087.
do we update action for java client? @acelyc111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951243614
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
@acelyc111
I remember github will show message and suggest merge master latest code if pr behind master, but recent, this feature seem to be closed?
Keep latest code base master before merging is necessary, I think we should revert the feature as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951243614
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
I remember github will show message and suggest merge master latest code if pr behind master, but recent, this feature seem to be closed? @acelyc111
Keep latest code base master before merging is necessary, I think we should revert the feature as above. @acelyc111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r952132525
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
@foreverneverer Rebase the master branch for every PR before merging into the master branch is too costly, and some unit tests are flacky, it will last a very long time.
I agree to @totalo , we can add some regular CI on master branch for Java, Go, and etc, code, as how cpp code is doing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r952161363
##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
result = 31 * result + (enableWriteLimit ? 1 : 0);
result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
- result = 31 * result + authProtocol.hashCode();
Review Comment:
Ok, it's also a resolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org