[GitHub] [cassandra] dcapwell commented on a diff in pull request #1432: CASSANDRA-17332 Add support for vnodes in jvm-dtest

[GitBox <gi...@apache.org>]

dcapwell commented on code in PR #1432:
URL: https://github.com/apache/cassandra/pull/1432#discussion_r844232043


##########
test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java:
##########
@@ -67,14 +69,15 @@ private InstanceConfig(int num,
                            String commitlog_directory,
                            String hints_directory,
                            String cdc_raw_directory,
-                           String initial_token,
+                           Collection<String> initial_token,
                            int storage_port,
                            int native_transport_port)
     {
         this.num = num;
         this.networkTopology = networkTopology;
         this.hostId = new UUID(0x4000L, (1L << 63) | num); // deterministic hostId for simulator
-        this    .set("num_tokens", 1)
+        this    .set("num_tokens", initial_token.size())

Review Comment:
   `public static constants for this` do you mean `num_tokens`?
   
   We could create a constants class, but rather not in this patch as this code base uses magic constants a lot already.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org