You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/09 12:42:04 UTC
[GitHub] [kafka] il-kyun opened a new pull request, #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig
il-kyun opened a new pull request, #12275:
URL: https://github.com/apache/kafka/pull/12275
- There is Optional<String> groupInstanceId field in ConsumerGroupMetadata class and GroupRebalanceConfig class and that is one of the Optional anti-patterns so I changes to String and use getter method to return Optional type.
- Add new ConsumerGroupMetadata constructor for if groupInstanceId not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac closed pull request #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig
Posted by GitBox <gi...@apache.org>.
dajac closed pull request #12275: MINOR: Change groupInstanceId type from Optional<String> to String in ConsumerGroupMetadata and GroupRebalanceConfig
URL: https://github.com/apache/kafka/pull/12275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig
Posted by GitBox <gi...@apache.org>.
dajac commented on PR #12275:
URL: https://github.com/apache/kafka/pull/12275#issuecomment-1240403160
Thanks @il-kyun for the patch. I looked into it and I don't think that the change is worth it. Using Optional here seems fine to me. I am going to close it for now. Feel free to reopen if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org