You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/17 13:03:14 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #5897: [HUDI-4277] supoort flink table source with computed column

danny0405 commented on code in PR #5897:
URL: https://github.com/apache/hudi/pull/5897#discussion_r900096001


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -156,7 +156,7 @@ public HoodieTableSource(
     this.fileIndex = FileIndex.instance(this.path, this.conf);
     this.requiredPartitions = requiredPartitions;
     this.requiredPos = requiredPos == null
-        ? IntStream.range(0, schema.getColumnCount()).toArray()
+        ? IntStream.range(0, schema.toPhysicalRowDataType().getChildren().size()).toArray()
         : requiredPos;
     this.limit = limit == null ? NO_LIMIT_CONSTANT : limit;

Review Comment:
   Thanks, can we try to add a test case in `ITTestHoodieDataSource`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org