You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chaoyu Tang <ct...@gmail.com> on 2016/03/10 18:39:29 UTC
Review Request 44664: HIVE-13243: Hive drop table on encyption zone
fails for external tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44664/
-----------------------------------------------------------
Review request for hive and Sergio Pena.
Bugs: HIVE-13243
https://issues.apache.org/jira/browse/HIVE-13243
Repository: hive-git
Description
-------
If the drop is for an external table, there is no need to check the Trash/Purge when deleting a file in encryption zone since no delete occurs
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0e8a157
ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea
ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out 55eefa0
Diff: https://reviews.apache.org/r/44664/diff/
Testing
-------
Manual test
New unit test
Precommit build test
Thanks,
Chaoyu Tang
Re: Review Request 44664: HIVE-13243: Hive drop table on encyption
zone fails for external tables
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44664/#review122951
-----------------------------------------------------------
Should we add some q-test on encryption_drop_partition.q for external table/partitions as well?
- Sergio Pena
On March 10, 2016, 5:39 p.m., Chaoyu Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44664/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 5:39 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-13243
> https://issues.apache.org/jira/browse/HIVE-13243
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> If the drop is for an external table, there is no need to check the Trash/Purge when deleting a file in encryption zone since no delete occurs
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0e8a157
> ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea
> ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out 55eefa0
>
> Diff: https://reviews.apache.org/r/44664/diff/
>
>
> Testing
> -------
>
> Manual test
> New unit test
> Precommit build test
>
>
> Thanks,
>
> Chaoyu Tang
>
>
Re: Review Request 44664: HIVE-13243: Hive drop table on encyption
zone fails for external tables
Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44664/
-----------------------------------------------------------
(Updated March 10, 2016, 10:25 p.m.)
Review request for hive and Sergio Pena.
Changes
-------
Uploaded a new patch with the fix to a typo in table name
Bugs: HIVE-13243
https://issues.apache.org/jira/browse/HIVE-13243
Repository: hive-git
Description
-------
If the drop is for an external table, there is no need to check the Trash/Purge when deleting a file in encryption zone since no delete occurs
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0e8a157
ql/src/test/queries/clientpositive/encryption_drop_partition.q a26aa19
ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea
ql/src/test/results/clientpositive/encrypted/encryption_drop_partition.q.out 067bf82
ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out 55eefa0
Diff: https://reviews.apache.org/r/44664/diff/
Testing
-------
Manual test
New unit test
Precommit build test
Thanks,
Chaoyu Tang
Re: Review Request 44664: HIVE-13243: Hive drop table on encyption
zone fails for external tables
Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44664/
-----------------------------------------------------------
(Updated March 10, 2016, 9:31 p.m.)
Review request for hive and Sergio Pena.
Changes
-------
Add test for drop partition of an external table. Thanks @Sergio Pena
Bugs: HIVE-13243
https://issues.apache.org/jira/browse/HIVE-13243
Repository: hive-git
Description
-------
If the drop is for an external table, there is no need to check the Trash/Purge when deleting a file in encryption zone since no delete occurs
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0e8a157
ql/src/test/queries/clientpositive/encryption_drop_partition.q a26aa19
ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea
ql/src/test/results/clientpositive/encrypted/encryption_drop_partition.q.out 067bf82
ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out 55eefa0
Diff: https://reviews.apache.org/r/44664/diff/
Testing
-------
Manual test
New unit test
Precommit build test
Thanks,
Chaoyu Tang