You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chao Sun <ch...@cloudera.com> on 2014/10/01 02:38:54 UTC

Review Request 26211: HIVE-8314 - Restore thrift string interning of HIVE-7975

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26211/
-----------------------------------------------------------

Review request for hive and Szehon Ho.


Bugs: HIVE-8314
    https://issues.apache.org/jira/browse/HIVE-8314


Repository: hive-git


Description
-------

In HIVE-7975 did string interning in thrift-generated code by having a google-replacer plugin run with -Pthriftif that does the replacements.
In commit of HIVE-7482, it was removed as it was done without that plugin. Thrift code should be regenerated.


Diffs
-----

  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java a993810 
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java 312807e 
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java 24d65bb 
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java d0b9843 

Diff: https://reviews.apache.org/r/26211/diff/


Testing
-------


Thanks,

Chao Sun