[jira] [Commented] (AMQ-3233) warnOnProducerFlowControl is never reset to 'true' after the first INFO message is logged.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894175#comment-15894175 ] 

ASF subversion and git services commented on AMQ-3233:
------------------------------------------------------

Commit 01b1f7f6945ba0897732b9eaae2ee1c9d50faf07 in activemq's branch refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=01b1f7f ]

[AMQ-3233] respect policy entry blockedProducerWarningInterval for flow control warning, 0 disables and Xmillis makes it periodic, default period of 30s is not unlike the existing once behaviour. fix and tests


> warnOnProducerFlowControl is never reset to 'true' after the first INFO message is logged.
> ------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3233
>                 URL: https://issues.apache.org/jira/browse/AMQ-3233
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.4.2
>         Environment: All
>            Reporter: Adrian Trenaman
>            Assignee: Gary Tully
>             Fix For: NEEDS_REVIEW
>
>
> Looking at the code in Queue.java (around line 543), you can see that the warnOnProducerFlowControl variable is set to false when we log the INFO message "Usage Manager Memory Limit (...) reached on ....". However, it is never set to true again. So, if we consider operations users trawling through large logs over a period of time, the may see the first warning on Monday, but then see no further warnings of this behavior for the rest of the week. Surely we should be resetting the warnOnProducerFlowControl variable to true, so that subsequent flow control situations are correctly logged?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)