You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mabrikan (via GitHub)" <gi...@apache.org> on 2023/03/01 12:42:34 UTC
[GitHub] [airflow] mabrikan opened a new pull request, #29838: Remove replicas if KEDA is enabled
mabrikan opened a new pull request, #29838:
URL: https://github.com/apache/airflow/pull/29838
Remove `replicas` field in workers Deployment/StatefulSet if KEDA is enabled
---
GitOps operators (e.g. ArgoCD) complain when the manifest is changed due to KEDA/HPA auto-scaling. The good practice is to remove `replicas` field when auto-scaling is used.
Reference:
https://argo-cd.readthedocs.io/en/stable/user-guide/best_practices/#leaving-room-for-imperativeness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mabrikan commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "mabrikan (via GitHub)" <gi...@apache.org>.
mabrikan commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1455064825
Sure thing :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] okayhooni commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "okayhooni (via GitHub)" <gi...@apache.org>.
okayhooni commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1451109195
I think current code change of this MR not considering the case that Airflow is deployed with KEDA enabled, not by GitOps tools like ArgoCD, but by Helm itself (more general case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454904373
needs static checks fixes and rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1463712448
I read a bit more and yeah - that's also official recommendation for HPA to not set replicas, so it should be OK to merge. https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#replicas
@dstandish @jedcunningham - shout if you think otherwise :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29838:
URL: https://github.com/apache/airflow/pull/29838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454949619
Nope. It happens in main - we need to fix it there first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1455053086
Can you please rebase @mabrikan -> I think the errors you see should have been fixed in main already, but it's good to double-check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mabrikan commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "mabrikan (via GitHub)" <gi...@apache.org>.
mabrikan commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454925728
Done, @potiuk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mabrikan closed pull request #29838: Remove replicas if KEDA is enabled
Posted by "mabrikan (via GitHub)" <gi...@apache.org>.
mabrikan closed pull request #29838: Remove replicas if KEDA is enabled
URL: https://github.com/apache/airflow/pull/29838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29838:
URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454935419
Looks like there are some side-effects of that change - the errors look quite related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org