You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2020/09/20 19:07:21 UTC
[wicket] branch wicket-8.x updated: WICKET-6702 do not serialize
asynchronously
This is an automated email from the ASF dual-hosted git repository.
svenmeier pushed a commit to branch wicket-8.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/wicket-8.x by this push:
new f105719 WICKET-6702 do not serialize asynchronously
f105719 is described below
commit f105719c9b15c1f11502cfea7c5bd71d2ced6901
Author: Sven Meier <sv...@apache.org>
AuthorDate: Sun Sep 20 20:58:30 2020 +0200
WICKET-6702 do not serialize asynchronously
---
.../org/apache/wicket/DefaultPageManagerProvider.java | 15 +--------------
.../apache/wicket/pageStore/AsynchronousPageStore.java | 2 ++
2 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java b/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
index f109472..0b5f997 100644
--- a/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
+++ b/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
@@ -57,25 +57,12 @@ public class DefaultPageManagerProvider implements IPageManagerProvider
IDataStore dataStore = newDataStore();
StoreSettings storeSettings = getStoreSettings();
-
- IPageStore pageStore;
-
if (dataStore.canBeAsynchronous() && storeSettings.isAsynchronous())
{
int capacity = storeSettings.getAsynchronousQueueCapacity();
dataStore = new AsynchronousDataStore(dataStore, capacity);
-
- pageStore = newPageStore(dataStore);
-
- if (pageStore.canBeAsynchronous())
- {
- pageStore = new AsynchronousPageStore(pageStore, capacity);
- }
- }
- else
- {
- pageStore = newPageStore(dataStore);
}
+ IPageStore pageStore = newPageStore(dataStore);
return new PageStoreManager(application.getName(), pageStore, pageManagerContext);
diff --git a/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousPageStore.java b/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousPageStore.java
index c3e5ba6..60aac2c 100644
--- a/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousPageStore.java
+++ b/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousPageStore.java
@@ -44,6 +44,8 @@ import org.slf4j.LoggerFactory;
* Based on AsynchronousDataStore (@author Matej Knopp).
*
* @author manuelbarzi
+ *
+ * @deprecated asynchronous page serialization might lead to concurrent modifications
*/
public class AsynchronousPageStore implements IPageStore
{