Re: [VOTE][PATCH]updates on forward only resultset using JDBC 2.0 UpdatableResultset APIs

[Edward Rayl <er...@bellsouth.net>]

Mamta Satoor wrote:

>On Mon, 21 Feb 2005 11:58:36 -0800, Mamta Satoor <ms...@gmail.com> wrote:
>  
>
>>Hi,
>>
>>I have addressed the comments made by Dan for performance. Here is the
>>new patch. Let me know what you all think.
>>
>>The comments made by Dan can be found in following thread
>>http://mail-archives.eu.apache.org/mod_mbox/db-derby-dev/200502.mbox/%3c42093858.C08AB984@Remulak.Net%3e
>>
>>I have run all the tests and they ran fine.
>>
>>svn stat output
>>M      java\engine\org\apache\derby\impl\jdbc\EmbedResultSet.java
>>M      java\engine\org\apache\derby\impl\jdbc\EmbedDatabaseMetaData.java
>>M      java\engine\org\apache\derby\impl\jdbc\EmbedResultSet20.java
>>M      java\engine\org\apache\derby\iapi\types\SQLClob.java
>>M      java\engine\org\apache\derby\iapi\reference\SQLState.java
>>M      java\engine\org\apache\derby\loc\messages_en.properties
>>M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\build.xml
>>M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\updatableResultSet.java
>>M      java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\resultsetJdbc30.java
>>M      java\testing\org\apache\derbyTesting\functionTests\master\resultsetJdbc30.out
>>M      java\testing\org\apache\derbyTesting\functionTests\master\parameterMapping.out
>>M      java\testing\org\apache\derbyTesting\functionTests\master\updatableResultSet.out
>>A      java\testing\org\apache\derbyTesting\functionTests\master\jdk14
>>A      java\testing\org\apache\derbyTesting\functionTests\master\jdk14\updatableResultSet.out
>>
>>thanks,
>>Mamta
>>
>>
>>
>>    
>>
>
>
>I wondered if anyone had any comments on this patch?
>
>thanks,
>Mamta
>  
>
I'm starting to wonder if this is on any of the reviewers' radar 
screen.  It's been two weeks with no comments.

Ed

Re: [VOTE][PATCH]updates on forward only resultset using JDBC 2.0 UpdatableResultset APIs

[Daniel John Debrunner <dj...@debrunners.com>]

Edward Rayl wrote:

> Dan,
> 
> I was afraid I might get that answer, and maybe I deserve it.  I know I
> need this feature for a project yesterday, but I have no experience in
> Derby database implementation details.

I wasn't aiming it at you directly, but trying to re-enforce that Derby
is an open source project and anyone can get involved.

And I'm feeling guilty because I have looked at the code, but haven't
got around to sending my comments yet. :-(

Dan.

Re: [VOTE][PATCH]updates on forward only resultset using JDBC 2.0 UpdatableResultset APIs

[Edward Rayl <er...@bellsouth.net>]

Dan,

I was afraid I might get that answer, and maybe I deserve it.  I know I 
need this feature for a project yesterday, but I have no experience in 
Derby database implementation details.  My comment is this feature is 
supported in most commercial and open source databases, for instance 
Oracle (commercial) and MySQL(open source).  It would allow for easier 
database and application migration.  As for review... you don't really 
want me doing that ;-)

Ed

>Edward Rayl wrote:
>
>  
>
>>I'm starting to wonder if this is on any of the reviewers' radar
>>screen.  It's been two weeks with no comments.
>>    
>>
>
>Just a reminder that anyone can review and comment on patches or code
>changes.
>
>Dan.
>
>
>
>  
>

Re: [VOTE][PATCH]updates on forward only resultset using JDBC 2.0 UpdatableResultset APIs

[Daniel John Debrunner <dj...@debrunners.com>]

Edward Rayl wrote:

>>
> I'm starting to wonder if this is on any of the reviewers' radar
> screen.  It's been two weeks with no comments.

Just a reminder that anyone can review and comment on patches or code
changes.

Dan.