You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Norbert Sándor (JIRA)" <ta...@jakarta.apache.org> on 2005/10/20 09:28:57 UTC

[jira] Created: (TAPESTRY-715) disabled LinkSubmit does not render it's body

disabled LinkSubmit does not render it's body
---------------------------------------------

         Key: TAPESTRY-715
         URL: http://issues.apache.org/jira/browse/TAPESTRY-715
     Project: Tapestry
        Type: Bug
  Components: Framework  
    Versions: 4.0    
 Environment: 4.0b11
    Reporter: Norbert Sándor


Body rendering is working now with enabled LinkSubmits. 

But if the LinkSubmit is disabled then: 
- renderFormComponent() is called when rendering 
- rewindFormComponent() is not called when rewinding. This is because AbstractFormComponent.renderComponent() contains the following condition: 

           if (!isDisabled()) 
           { 
                 rewindFormComponent(writer, cycle); 
           } 

So in case of disabled LinkSubmits the component's body is not rendered when rewinding which may cause StaleLinkException. 

Maybe the isDisabled() check should go to a higher level allowing the components to decide whether they want to perform any operation or not - the same way as during rendering.

BR, 
Norbi 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Closed: (TAPESTRY-715) LinkSubmit component should render its body, even when disabled

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-715?page=all ]
     
Howard M. Lewis Ship closed TAPESTRY-715:
-----------------------------------------

    Fix Version: 4.0
     Resolution: Fixed

> LinkSubmit component should render its body, even when disabled
> ---------------------------------------------------------------
>
>          Key: TAPESTRY-715
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-715
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>  Environment: 4.0b11
>     Reporter: Norbert Sándor
>     Assignee: Howard M. Lewis Ship
>      Fix For: 4.0

>
> Body rendering is working now with enabled LinkSubmits. 
> But if the LinkSubmit is disabled then: 
> - renderFormComponent() is called when rendering 
> - rewindFormComponent() is not called when rewinding. This is because AbstractFormComponent.renderComponent() contains the following condition: 
>            if (!isDisabled()) 
>            { 
>                  rewindFormComponent(writer, cycle); 
>            } 
> So in case of disabled LinkSubmits the component's body is not rendered when rewinding which may cause StaleLinkException. 
> Maybe the isDisabled() check should go to a higher level allowing the components to decide whether they want to perform any operation or not - the same way as during rendering.
> BR, 
> Norbi 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Updated: (TAPESTRY-715) LinkSubmit component should render its body, even when disabled

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-715?page=all ]

Howard M. Lewis Ship updated TAPESTRY-715:
------------------------------------------

      Summary: LinkSubmit component should render its body, even when disabled  (was: disabled LinkSubmit does not render it's body)
    Assign To: Howard M. Lewis Ship

> LinkSubmit component should render its body, even when disabled
> ---------------------------------------------------------------
>
>          Key: TAPESTRY-715
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-715
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>  Environment: 4.0b11
>     Reporter: Norbert Sándor
>     Assignee: Howard M. Lewis Ship

>
> Body rendering is working now with enabled LinkSubmits. 
> But if the LinkSubmit is disabled then: 
> - renderFormComponent() is called when rendering 
> - rewindFormComponent() is not called when rewinding. This is because AbstractFormComponent.renderComponent() contains the following condition: 
>            if (!isDisabled()) 
>            { 
>                  rewindFormComponent(writer, cycle); 
>            } 
> So in case of disabled LinkSubmits the component's body is not rendered when rewinding which may cause StaleLinkException. 
> Maybe the isDisabled() check should go to a higher level allowing the components to decide whether they want to perform any operation or not - the same way as during rendering.
> BR, 
> Norbi 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org