Change in asterixdb[master]: [COMP][ASTERIXDB-3041] Index usage w/ OBJECT_* functions.

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Wail Alkowaileet <wa...@gmail.com>:

Attention is currently required from: Glenn Galvizo.
Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843 )

Change subject: [COMP][ASTERIXDB-3041] Index usage w/ OBJECT_* functions.
......................................................................


Patch Set 8:

(4 comments)

File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843/comment/58c0b12a_2f12ff2f 
PS8, Line 3040: AbstractFunctionCallExpression
(I'm not too familiar with Access Methods)
Is the expression here guaranteed to be a function call?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843/comment/caf94306_23ff0b25 
PS8, Line 3241: FUNCTION_WHITELIST
Let's have the whitelist as a static final set (easier to spot for newcomers who want to expand the set)


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843/comment/3739019f_691f6a78 
PS8, Line 3259: // Extract the type of our input (for all whitelist functions right now, this is this the first argument).
              :         final int indexOfInputRecord = 0;
Maybe in a followup change, could object_concat be included to the whitelist in the future? If so, we might want to generalize that to check every argument?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843/comment/129c4c4d_64986624 
PS8, Line 3286: true
The variable might not be originated from a data source. For example:

SELECT object_remove(x, "b")
FROM [{"a":1, "b":2}] x

Not sure if that a valid point as such UNNEST might not reach here.



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16843
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I2c64319981f504736cea8732b3ec985d5c913dd3
Gerrit-Change-Number: 16843
Gerrit-PatchSet: 8
Gerrit-Owner: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Reviewer: Wail Alkowaileet <wa...@gmail.com>
Gerrit-Attention: Glenn Galvizo <gg...@uci.edu>
Gerrit-Comment-Date: Tue, 06 Sep 2022 23:34:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment