You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/06 20:19:48 UTC
Review Request 37194: Fixed a bug in the MesosContainerizer creation
logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Repository: mesos
Description
-------
Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
Diff: https://reviews.apache.org/r/37194/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 37194: Fixed a bug in the MesosContainerizer
creation logic.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 6, 2015, 8:43 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 132
> > <https://reviews.apache.org/r/37194/diff/1/?file=1033640#file1033640line132>
> >
> > Just a question when looking at this code again, is it possible for a user to specifiy a empty string in flags.isolation, which overrides the default value and we end up a bad string with this?
Yeah, it's possible. But we use 'strings::tokenize' below, which will correctly handle this case.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/#review94442
-----------------------------------------------------------
On Aug. 6, 2015, 6:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37194/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 6:19 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
>
> The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
>
> Diff: https://reviews.apache.org/r/37194/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37194: Fixed a bug in the MesosContainerizer
creation logic.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/#review94442
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 132)
<https://reviews.apache.org/r/37194/#comment149050>
Just a question when looking at this code again, is it possible for a user to specifiy a empty string in flags.isolation, which overrides the default value and we end up a bad string with this?
- Timothy Chen
On Aug. 6, 2015, 6:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37194/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 6:19 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
>
> The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
>
> Diff: https://reviews.apache.org/r/37194/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37194: Fixed a bug in the MesosContainerizer
creation logic.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/#review94444
-----------------------------------------------------------
Ship it!
Ship It!
src/slave/containerizer/mesos/containerizer.cpp (line 132)
<https://reviews.apache.org/r/37194/#comment149052>
Makes sense
- Timothy Chen
On Aug. 6, 2015, 6:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37194/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 6:19 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
>
> The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
>
> Diff: https://reviews.apache.org/r/37194/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37194: Fixed a bug in the MesosContainerizer
creation logic.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/#review94463
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36929, 36930, 36954, 36956, 37054, 37055, 37091, 37105, 37142, 37159, 37194]
All tests passed.
- Mesos ReviewBot
On Aug. 6, 2015, 6:19 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37194/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 6:19 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
>
> The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
>
> Diff: https://reviews.apache.org/r/37194/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37194: Fixed a bug in the MesosContainerizer
creation logic.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 12:18 a.m.)
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-2794
https://issues.apache.org/jira/browse/MESOS-2794
Repository: mesos
Description
-------
Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and added a few more comments in the patch as well.
The bug is that currently we only put filesystem isolator to the front if it's coming from modules.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
Diff: https://reviews.apache.org/r/37194/diff/
Testing
-------
make check
Thanks,
Jie Yu