You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2017/02/23 09:44:18 UTC

[GitHub] zeppelin pull request #2059: [ZEPPELIN-2139] Interpreters based on scala_2.1...

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/2059

    [ZEPPELIN-2139] Interpreters based on scala_2.11 aren't installed correctly

    ### What is this PR for?
    pom variables such as `${scala.version}` are not replaced to value when you do mvn install.
    This causes leaf poms to look for this value in parent pom, which is always `2.10.5` and bring scala library dependency conflict. For example, zeppelin-flink_2.11 will have scala 2.10.5 as dependency.
    This PR fixes this problem by using maven flatten plugin.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-2139](https://issues.apache.org/jira/browse/ZEPPELIN-2139)
    
    ### How should this be tested?
    ```
    $ ./dev/change_scala_version.sh 2.11
    $ mvn clean install -pl 'zeppelin-server,zeppelin-zengine,zeppelin-interpreter,flink' -am -DskipRat -DskipTests -Pscala-2.11
    ```
    Open `~/.m2/repository/org/apache/zeppelin/zeppelin-flink_2.11/0.8.0-SNAPSHOT/zeppelin-flink_2.11-0.8.0-SNAPSHOT.pom` file and see if scala related libraries dependency version is set to 2.11.7
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-2139

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2059.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2059
    
----
commit 301a555b23472b8a9abf8c34c33b05c1190c3b49
Author: Mina Lee <mi...@apache.org>
Date:   2017-02-23T05:59:52Z

    Fix indentation and add default properties to be used in flattened-pom

commit 0acdec0189ac8f1b18e66cd22000c1fdaafde905
Author: Mina Lee <mi...@apache.org>
Date:   2017-02-23T07:32:41Z

    Use maven flatten plugin to make pom.xml variables to be replaced by value

commit 38bad9b5134f34d825d080266d2135b13ecdc978
Author: Mina Lee <mi...@apache.org>
Date:   2017-02-23T09:21:35Z

    Change <scala.version> property in parent pom file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2059: [ZEPPELIN-2139] Interpreters based on scala_2.1...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2059


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2059: [ZEPPELIN-2139] Interpreters based on scala_2.11 aren'...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/2059
  
    Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---