You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/09 04:33:08 UTC
[GitHub] [spark] ulysses-you opened a new pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
ulysses-you opened a new pull request #29688:
URL: https://github.com/apache/spark/pull/29688
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new config `spark.sql.maxMetadataStringLength`. This config aims to limit metadata value length, e.g. file location.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Some metadata have been abbreviated by `...` when I tried to add some test in `SQLQueryTestSuite`. We need to replace such value to `notIncludedMsg`. That caused we can't replace that like location value by `className` since the `className` has been abbreviated.
Here is a case:
```
CREATE table explain_temp1 (key int, val int) USING PARQUET;
EXPLAIN EXTENDED SELECT sum(distinct val) FROM explain_temp1;
-- ignore parsed,analyzed,optimized
-- The output like
== Physical Plan ==
*HashAggregate(keys=[], functions=[sum(distinct cast(val#x as bigint)#xL)], output=[sum(DISTINCT val)#xL])
+- Exchange SinglePartition, true, [id=#x]
+- *HashAggregate(keys=[], functions=[partial_sum(distinct cast(val#x as bigint)#xL)], output=[sum#xL])
+- *HashAggregate(keys=[cast(val#x as bigint)#xL], functions=[], output=[cast(val#x as bigint)#xL])
+- Exchange hashpartitioning(cast(val#x as bigint)#xL, 4), true, [id=#x]
+- *HashAggregate(keys=[cast(val#x as bigint) AS cast(val#x as bigint)#xL], functions=[], output=[cast(val#x as bigint)#xL])
+- *ColumnarToRow
+- FileScan parquet default.explain_temp1[val#x] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex[file:/home/runner/work/spark/spark/sql/core/spark-warehouse/org.apache.spark.sq...], PartitionFilters: ...
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, a new config.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689298793
**[Test build #128435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128435/testReport)** for PR 29688 at commit [`eb67ccd`](https://github.com/apache/spark/commit/eb67ccd435b13784c1a14595e805b69bff81069d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691746162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689296115
**[Test build #128434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128434/testReport)** for PR 29688 at commit [`7b676b8`](https://github.com/apache/spark/commit/7b676b8c8db12bb30358d8f13721a1b841ff7c88).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485450580
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
+ withTempDir { dir =>
+ val tableName = "t1"
+ val path = s"${dir.getCanonicalPath}/$tableName"
+ withTable(tableName) {
+ sql(s"create table t1(c int) using parquet location '$path'")
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689353887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128435/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485453573
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2370,6 +2370,14 @@ object SQLConf {
"(nonnegative and shorter than the maximum size).")
.createWithDefaultString(s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}")
+ val MAX_METADATA_STRING_LENGTH = buildConf("spark.sql.maxMetadataStringLength")
+ .doc("Maximum number of characters to output for a metadata string. e.g. " +
+ "file location in `DataSourceScanExec`, every value will be abbreviated if exceed length.")
+ .version("3.1.0")
+ .intConf
+ .checkValue(_ > 3, "This value must be bigger than 3.")
Review comment:
This value from `org.apache.commons.lang3.StringUtils.abbreviate` whose marker is `...`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689432986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691595150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689299257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689427681
**[Test build #128443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128443/testReport)** for PR 29688 at commit [`239f62b`](https://github.com/apache/spark/commit/239f62bc7f58cac1a690b123ce37acfdd2279422).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-693090768
Thanks for merging, thanks all !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689585569
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128444/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689355209
@maropu @dongjoon-hyun @cloud-fan do you have time to look this ? thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689585554
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689432986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689353365
**[Test build #128435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128435/testReport)** for PR 29688 at commit [`eb67ccd`](https://github.com/apache/spark/commit/eb67ccd435b13784c1a14595e805b69bff81069d).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691207647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485408952
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2370,6 +2370,13 @@ object SQLConf {
"(nonnegative and shorter than the maximum size).")
.createWithDefaultString(s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}")
+ val MAX_METADATA_STRING_LENGTH = buildConf("spark.sql.maxMetadataStringLength")
+ .doc("Maximum number of characters to output for a metadata string. e.g. " +
+ "`DataSourceScanExec`, every value will be abbreviated if exceed length.")
Review comment:
`e.g. DataSourceScanExec` => `e.g. file location in DataSourceScanExec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689432286
**[Test build #128444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128444/testReport)** for PR 29688 at commit [`681f84e`](https://github.com/apache/spark/commit/681f84e4991bc2477e9354f29b1d2841ae5b656e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689296486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691746162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689297086
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689643372
Glad to see this happening @ulysses-you ! We have a similar internal patch we added recently that we've been planning to open source. Nice to see that the changes are even simpler on the 3.x line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689585554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689432286
**[Test build #128444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128444/testReport)** for PR 29688 at commit [`681f84e`](https://github.com/apache/spark/commit/681f84e4991bc2477e9354f29b1d2841ae5b656e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691207647
@ulysses-you thanks for the work.
It seems that the PR only changes the file source related metadata. Is there other places we can use the new config as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r487171789
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691808560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691593417
Thanks @gengliangwang .The origin propose is for explain test what I said in pr description, related pr is [#29586](https://github.com/apache/spark/pull/29586). Location value has been abbreviated by `...` since default metadata length is 100. We can add the config at head of test file like `--SET spark.sql.maxMetadataStringLength=500;` if we have this config, then we can get the total location value.
I'm not sure if it's well to do these change in one pr. But I can merge them into one pr if you think it's ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29688:
URL: https://github.com/apache/spark/pull/29688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691207647
@ulysses-you thanks for the work.
It seems that the PR only changes the file source related metadata. Is there other places we can use the new config as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689353879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689296115
**[Test build #128434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128434/testReport)** for PR 29688 at commit [`7b676b8`](https://github.com/apache/spark/commit/7b676b8c8db12bb30358d8f13721a1b841ff7c88).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689427681
**[Test build #128443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128443/testReport)** for PR 29688 at commit [`239f62b`](https://github.com/apache/spark/commit/239f62bc7f58cac1a690b123ce37acfdd2279422).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691745941
**[Test build #128611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128611/testReport)** for PR 29688 at commit [`e83bf95`](https://github.com/apache/spark/commit/e83bf958828cd7b893c17e6962f2d63725632eec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689607610
**[Test build #128443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128443/testReport)** for PR 29688 at commit [`239f62b`](https://github.com/apache/spark/commit/239f62bc7f58cac1a690b123ce37acfdd2279422).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689297086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689296486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689388959
Adding the config looks okay to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689298793
**[Test build #128435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128435/testReport)** for PR 29688 at commit [`eb67ccd`](https://github.com/apache/spark/commit/eb67ccd435b13784c1a14595e805b69bff81069d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-692427476
> @ulysses-you thanks for the work.
> It seems that the PR only changes the file source related metadata. Is there other places we can use the new config as well?
I will use this config in my pr https://github.com/apache/spark/pull/29739.
Similar work in my pr and reverted waiting this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691624198
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689428477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691624037
**[Test build #128596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128596/testReport)** for PR 29688 at commit [`9c19245`](https://github.com/apache/spark/commit/9c19245d82e4f0842d872cfe1f992d05d844c601).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689428477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r487171789
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r487171789
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
Review comment:
Nit: `Add spark.sql.maxMetadataStringLength config` => `Set max metadata string length`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689584269
**[Test build #128444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128444/testReport)** for PR 29688 at commit [`681f84e`](https://github.com/apache/spark/commit/681f84e4991bc2477e9354f29b1d2841ae5b656e).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691745941
**[Test build #128611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128611/testReport)** for PR 29688 at commit [`e83bf95`](https://github.com/apache/spark/commit/e83bf958828cd7b893c17e6962f2d63725632eec).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689353879
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691808116
**[Test build #128611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128611/testReport)** for PR 29688 at commit [`e83bf95`](https://github.com/apache/spark/commit/e83bf958828cd7b893c17e6962f2d63725632eec).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689609462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691624200
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128596/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691624200
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128596/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691595012
**[Test build #128596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128596/testReport)** for PR 29688 at commit [`9c19245`](https://github.com/apache/spark/commit/9c19245d82e4f0842d872cfe1f992d05d844c601).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689609462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485409379
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
+ withTempDir { dir =>
+ val tableName = "t1"
Review comment:
nit: `t1` -> `t`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691595012
**[Test build #128596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128596/testReport)** for PR 29688 at commit [`9c19245`](https://github.com/apache/spark/commit/9c19245d82e4f0842d872cfe1f992d05d844c601).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485409893
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -881,6 +882,28 @@ class FileBasedDataSourceSuite extends QueryTest
}
}
}
+
+ test("SPARK-32827: Add spark.sql.maxMetadataStringLength config") {
+ withTempDir { dir =>
+ val tableName = "t1"
+ val path = s"${dir.getCanonicalPath}/$tableName"
+ withTable(tableName) {
+ sql(s"create table t1(c int) using parquet location '$path'")
Review comment:
plz use uppercases for SQL keywords, e.g., `CREATE TABLE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485409066
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2370,6 +2370,13 @@ object SQLConf {
"(nonnegative and shorter than the maximum size).")
.createWithDefaultString(s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}")
+ val MAX_METADATA_STRING_LENGTH = buildConf("spark.sql.maxMetadataStringLength")
+ .doc("Maximum number of characters to output for a metadata string. e.g. " +
+ "`DataSourceScanExec`, every value will be abbreviated if exceed length.")
+ .version("3.1.0")
+ .intConf
Review comment:
plz add `checkValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689297065
**[Test build #128434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128434/testReport)** for PR 29688 at commit [`7b676b8`](https://github.com/apache/spark/commit/7b676b8c8db12bb30358d8f13721a1b841ff7c88).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689299257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #29688:
URL: https://github.com/apache/spark/pull/29688#discussion_r485453573
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2370,6 +2370,14 @@ object SQLConf {
"(nonnegative and shorter than the maximum size).")
.createWithDefaultString(s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}")
+ val MAX_METADATA_STRING_LENGTH = buildConf("spark.sql.maxMetadataStringLength")
+ .doc("Maximum number of characters to output for a metadata string. e.g. " +
+ "file location in `DataSourceScanExec`, every value will be abbreviated if exceed length.")
+ .version("3.1.0")
+ .intConf
+ .checkValue(_ > 3, "This value must be bigger than 3.")
Review comment:
This value if from `org.apache.commons.lang3.StringUtils.abbreviate` whose marker is `...`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-692741397
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691595150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-689297091
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128434/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29688: [SPARK-32827][SQL] Add spark.sql.maxMetadataStringLength config
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29688:
URL: https://github.com/apache/spark/pull/29688#issuecomment-691808560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org