You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 03:09:03 UTC
Review Request 66326: Added tests for agent resource provider API
idempotency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66326/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Bugs: MESOS-8742
https://issues.apache.org/jira/browse/MESOS-8742
Repository: mesos
Description
-------
This patche adds tests to verify that adding, updating and removing the
same resource provider config will return 200 OK without triggering any
resource provider launch/termination.
Diffs
-----
src/tests/agent_resource_provider_config_api_tests.cpp 53b8cb8f9463dec5fa684e64c61a3ad5b6c88104
Diff: https://reviews.apache.org/r/66326/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66326: Added tests for agent resource provider API
idempotency.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66326/#review200155
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 28, 2018, 3:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66326/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 3:09 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8742
> https://issues.apache.org/jira/browse/MESOS-8742
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patche adds tests to verify that adding, updating and removing the
> same resource provider config will return 200 OK without triggering any
> resource provider launch/termination.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 53b8cb8f9463dec5fa684e64c61a3ad5b6c88104
>
>
> Diff: https://reviews.apache.org/r/66326/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66326: Added tests for agent resource provider API
idempotency.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66326/#review200093
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66318', '66325', '66326']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66326
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66326/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (108 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1034 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (69 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (744 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (767 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (731 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (753 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (429420 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66326/logs/mesos-tests-stderr.log):
```
I0328 04:08:42.594311 3856 exec.cpp:236] Executor registered on agent adad2926-091b-46da-bc2b-d9283256f266-S0
I0328 04:08:42.598310 8172 executor.cpp:176] Received SUBSCRIBED event
I0328 04:08:42.602340 8172 executor.cpp:180] Subscribed executor on winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0328 04:08:42.603307 8172 executor.cpp:176] Received LAUNCH event
I0328 04:08:42.607303 8172 executor.cpp:648] Starting task 2d20625e-45c9-4512-900d-7f83a2aa494f
I0328 04:08:42.688307 8172 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0328 04:08:42.722344 8172 executor.cpp:661] Forked command at 4312
I0328 04:08:42.750303 4444 exec.cpp:445] Executor asked to shutdown
I0328 04:08:42.750303 5736 executor.cpp:176] Received SHUTDOWN event
I0328 04:08:42.750303 5736 executor.cpp:758] Shutting down
I0328 04:08:42.750303 5736 executor.cpp:868] Sending SIGTERM to process tree at pid 4al.cpp:405] Deactivated framework adad2926-091b-46da-bc2b-d9283256f266-0000
I0328 04:08:42.748447 8028 slave.cpp:3873] Shutting down framework adad2926-091b-46da-bc2b-d9283256f266-0000
I0328 04:08:42.748447 4984 master.cpp:10446] Updating the state of task 2d20625e-45c9-4512-900d-7f83a2aa494f of framework adad2926-091b-46da-bc2b-d9283256f266-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0328 04:08:42.748447 8028 slave.cpp:6566] Shutting down executor '2d20625e-45c9-4512-900d-7f83a2aa494f' of framework adad2926-091b-46da-bc2b-d9283256f266-0000 at executor(1)@10.3.1.5:62338
I0328 04:08:42.749302 8028 slave.cpp:919] Agent terminating
W0328 04:08:42.749302 8028 slave.cpp:3869] Ignoring shutdown framework adad2926-091b-46da-bc2b-d9283256f266-0000 because it is terminating
I0328 04:08:42.751302 4984 master.cpp:10545] Removing task 2d20625e-45c9-4512-900d-7f83a2aa494f with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework adad2926-091b-46da-bc2b-d9283256f266-0000 on agent adad2926-091b-46da-bc2b-d9283256f266-S0 at slave(418)@10.3.1.5:62317 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 04:08:42.753310 4988 containerizer.cpp:2338] Destroying container 72d1f9a3-036a-4461-9735-090203ffc7ae in RUNNING state
I0328 04:08:42.753310 4988 containerizer.cpp:2952] Transitioning the state of container 72d1f9a3-036a-4461-9735-090203ffc7ae from RUNNING to DESTROYING
I0328 04:08:42.754333 4984 master.cpp:1295] Agent adad2926-091b-46da-bc2b-d9283256f266-S0 at slave(418)@10.3.1.5:62317 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0328 04:08:42.754333 4984 master.cpp:3283] Disconnecting agent adad2926-091b-46da-bc2b-d9283256f266-S0 at slave(418)@10.3.1.5:62317 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 04:08:42.754333 4988 launcher.cpp:156] Asked to destroy container 72d1f9a3-036a-4461-9735-090203ffc7ae
I0328 04:08:42.754333 4984 master.cpp:3302] Deactivating agent adad2926-091b-46da-bc2b-d9283256f266-S0 at slave(418)@10.3.1.5:62317 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 04:08:42.754333 3960 hierarchical.cpp:344] Removed framework adad2926-091b-46da-bc2b-d9283256f266-0000
I0328 04:08:42.755314 3960 hierarchical.cpp:766] Agent adad2926-091b-46da-bc2b-d9283256f266-S0 deactivated
I0328 04:08:42.781316 12216 containerizer.cpp:2791] Container 72d1f9a3-036a-4461-9735-090203ffc7ae has exited
I0328 04:08:42.811316 7580 master.cpp:1137] Master terminating
I0328 04:08:42.813300 4988 hierarchical.cpp:609] Removed agent adad2926-091b-46da-bc2b-d9283256f266-S0
I0328 04:08:43.203331 9028 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 28, 2018, 5:09 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66326/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 5:09 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8742
> https://issues.apache.org/jira/browse/MESOS-8742
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patche adds tests to verify that adding, updating and removing the
> same resource provider config will return 200 OK without triggering any
> resource provider launch/termination.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 53b8cb8f9463dec5fa684e64c61a3ad5b6c88104
>
>
> Diff: https://reviews.apache.org/r/66326/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>