[GitHub] [skywalking] mrproliu commented on pull request #7495: Banyandb storage plugin

[GitBox <gi...@apache.org>]

mrproliu commented on pull request #7495:
URL: https://github.com/apache/skywalking/pull/7495#issuecomment-902433025


   > @mrproliu
   > 
   > ![image](https://user-images.githubusercontent.com/2568208/130177857-b6fbb1d7-f0d7-461f-9641-1005f3505ebb.png)
   > 
   > I am using `${provider_host}` as a placeholder to get IP and port for the services defined in `docker-compose` file. But It seems that all placeholders are returning blank string. Also it can be reproducible on both macOS and Linux.
   
   You need to declare which ports need to export to the environment, please add port declare into `docker-compose.yaml` file, here is a [demo link](https://github.com/apache/skywalking-satellite/blob/main/test/e2e/case/native-protocols/docker-compose.yml#L50-L51). 
   
   > Is this related to [apache/skywalking-infra-e2e#36](https://github.com/apache/skywalking-infra-e2e/pull/36)?
   
   After you change the `docker-compose.yml` port declare, the E2E may still fail, this PR it's to fix this problem, that's two different problems. After this PR has been merge, I will mention you to update the commit id. 
   
   > Another feature request: can we provide an `env` field that allow to pass environments downwards into the container in Github Action environment.
   
   Could you do more explain on this? which environment field do you want?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org