You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/08/10 15:09:11 UTC

[PR] [ISSUE #10899] Fix missing message-out metrics for KV POP [rocketmq]

majialoong opened a new pull request, #10900:
URL: https://github.com/apache/rocketmq/pull/10900

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   - Fixes #10899 
   
   ### Brief Description
   
   Fix missing BrokerStats and OTel message-out metrics in KV POP, restoring Consume TPS and aligning the statistics with traditional POP.
   
   ### How Did You Test This Change?
   
   Added unit tests and performed local KV POP verification. Confirmed the updated Consume TPS through `mqadmin consumerProgress` and the related statistics in `stats.log`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10899] Fix missing message-out metrics for KV POP [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10900:
URL: https://github.com/apache/rocketmq/pull/10900#issuecomment-5242499748

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10900?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `94.44444%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.33%. Comparing base ([`e345861`](https://app.codecov.io/gh/apache/rocketmq/commit/e3458616d207ee636b1762f0f8dcf788a590d59d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`deae8c8`](https://app.codecov.io/gh/apache/rocketmq/commit/deae8c8ef5e25268219977cf242e4da26fde239e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10900?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/rocketmq/broker/pop/PopConsumerService.java](https://app.codecov.io/gh/apache/rocketmq/pull/10900?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fpop%2FPopConsumerService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcG9wL1BvcENvbnN1bWVyU2VydmljZS5qYXZh) | 94.44% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10900      +/-   ##
   =============================================
   - Coverage      48.43%   48.33%   -0.10%     
   + Complexity     13575    13544      -31     
   =============================================
     Files           1380     1380              
     Lines         101165   101183      +18     
     Branches       13127    13130       +3     
   =============================================
   - Hits           48995    48906      -89     
   - Misses         46210    46283      +73     
   - Partials        5960     5994      +34     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10900?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10899] Fix missing message-out metrics for KV POP [rocketmq]

Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #10900:
URL: https://github.com/apache/rocketmq/pull/10900#issuecomment-5290219086

   Hi @lizhimins , please take a look at this PR when have time, thanks !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org