You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/02/28 06:33:28 UTC

Review Request 18610: On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18610/
-----------------------------------------------------------

Review request for Ambari, Mahadev Konar and Sumit Mohanty.


Bugs: AMBARI-4878
    https://issues.apache.org/jira/browse/AMBARI-4878


Repository: ambari


Description
-------

On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

Note:

{code}
17:31:38,216  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
17:31:48,227  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
17:31:54,997  WARN [qtp1459326258-137] HeartBeatHandler:346 - Operation failed - may be retried. Service component host: OOZIE_SERVER, host: hostname1 Action id1-1

{code}

that this is after all the tasks in request 1 were aborted. This part makes the state of OOZIE_SERVER go into INSTALL_FAILED though the req 1 was aborted. 

Any further update on success from the agent is ignored for this component.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 789bbd6 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 0044c8e 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 490df5e 

Diff: https://reviews.apache.org/r/18610/diff/


Testing
-------


Thanks,

Sid Wagle


Re: Review Request 18610: On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

Posted by Sumit Mohanty <sm...@hortonworks.com>.

> On Feb. 28, 2014, 5:39 a.m., Sumit Mohanty wrote:
> > Ship It!

Minor nit:
Change "Report arrived after command is no longer running ..." to "Received report for a command that is no longer active ...". Also, do we log the command id when this happens?


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18610/#review35763
-----------------------------------------------------------


On Feb. 28, 2014, 5:33 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18610/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 5:33 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4878
>     https://issues.apache.org/jira/browse/AMBARI-4878
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.
> 
> Note:
> 
> {code}
> 17:31:38,216  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
> 17:31:48,227  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
> 17:31:54,997  WARN [qtp1459326258-137] HeartBeatHandler:346 - Operation failed - may be retried. Service component host: OOZIE_SERVER, host: hostname1 Action id1-1
> 
> {code}
> 
> that this is after all the tasks in request 1 were aborted. This part makes the state of OOZIE_SERVER go into INSTALL_FAILED though the req 1 was aborted. 
> 
> Any further update on success from the agent is ignored for this component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 789bbd6 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 0044c8e 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 490df5e 
> 
> Diff: https://reviews.apache.org/r/18610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 18610: On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18610/#review35763
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Feb. 28, 2014, 5:33 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18610/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 5:33 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4878
>     https://issues.apache.org/jira/browse/AMBARI-4878
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.
> 
> Note:
> 
> {code}
> 17:31:38,216  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
> 17:31:48,227  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
> 17:31:54,997  WARN [qtp1459326258-137] HeartBeatHandler:346 - Operation failed - may be retried. Service component host: OOZIE_SERVER, host: hostname1 Action id1-1
> 
> {code}
> 
> that this is after all the tasks in request 1 were aborted. This part makes the state of OOZIE_SERVER go into INSTALL_FAILED though the req 1 was aborted. 
> 
> Any further update on success from the agent is ignored for this component.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 789bbd6 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 0044c8e 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 490df5e 
> 
> Diff: https://reviews.apache.org/r/18610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 18610: On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18610/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 5:54 a.m.)


Review request for Ambari, Mahadev Konar and Sumit Mohanty.


Bugs: AMBARI-4878
    https://issues.apache.org/jira/browse/AMBARI-4878


Repository: ambari


Description
-------

On a retry all the install commands succeed but the status of one of the components in INSTALL_FAILED which causes the next START command to fail on UI.

Note:

{code}
17:31:38,216  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
17:31:48,227  WARN [qtp1459326258-137] ActionManager:142 - The task 27 is not in progress, ignoring update
17:31:54,997  WARN [qtp1459326258-137] HeartBeatHandler:346 - Operation failed - may be retried. Service component host: OOZIE_SERVER, host: hostname1 Action id1-1

{code}

that this is after all the tasks in request 1 were aborted. This part makes the state of OOZIE_SERVER go into INSTALL_FAILED though the req 1 was aborted. 

Any further update on success from the agent is ignored for this component.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java 789bbd6 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 0044c8e 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 490df5e 

Diff: https://reviews.apache.org/r/18610/diff/


Testing (updated)
-------

Results :

Tests run: 1471, Failures: 0, Errors: 0, Skipped: 11


Thanks,

Sid Wagle