You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Alexander Broekhuis <a....@gmail.com> on 2014/09/29 08:57:11 UTC
Re: [jira] [Updated] (CELIX-154) echo exampe not working
Thanks for creating an issue.
I've been looking at the patch a bit, and noticed you enabled all warnings.
While I think this is a good idea, I've created a separate issue for it [1].
Normally I prefer patches for 1 module, yours included a few fixed for
files not related to the echo example as well. I will commit those fixes
under the issue at [1].
Is the "-pthread" needed on Linux? I haven't had any problems on OSX
without it, and do get a warning when using it. If it is needed an extra
check is needed to not use it on OSX, but for other UNIXes.
Ps: You also included a patch file in the patch, I assume this was not
intentional, and just ignored the file.
Pps: I also updated the ident of the echo_client to a better suited text
(sorry, couldn't resist :)).
[1]: https://issues.apache.org/jira/browse/CELIX-156
2014-09-28 22:04 GMT+02:00 Erjan Altena (JIRA) <ji...@apache.org>:
>
> [
> https://issues.apache.org/jira/browse/CELIX-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Erjan Altena updated CELIX-154:
> -------------------------------
> Description:
> The echo echo-example was not working. I made a fix. It does not rely any
> more an apr but on posix threads.
>
> I added also a small error message fix and enabled compiler warnings.
>
> The attached patch is based on the current trunk. If you lke to have it
> in another format please let me know.
>
> was:
> The echo echo-example was not working. I made a fix. It does not rely any
> more an apr but on posix threads.
>
> I added also a small error message fix and enabled compiler warnings.
>
> The fix is a patcn on current trunk. If you lke to have it in another
> format please let me know.
>
>
> > echo exampe not working
> > -----------------------
> >
> > Key: CELIX-154
> > URL: https://issues.apache.org/jira/browse/CELIX-154
> > Project: Celix
> > Issue Type: Bug
> > Components: Examples
> > Affects Versions: next-incubating
> > Environment: linux 32 bit
> > Reporter: Erjan Altena
> > Priority: Minor
> > Fix For: next-incubating
> >
> > Attachments: echo_example_fix.patch
> >
> >
> > The echo echo-example was not working. I made a fix. It does not rely
> any more an apr but on posix threads.
> > I added also a small error message fix and enabled compiler warnings.
> > The attached patch is based on the current trunk. If you lke to have it
> in another format please let me know.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [jira] [Updated] (CELIX-154) echo exampe not working
Posted by Alexander Broekhuis <a....@gmail.com>.
I've created an issue for this at [1]. I will also look into what is needed
for CLang.
[1]: https://issues.apache.org/jira/browse/CELIX-159
2014-09-29 20:48 GMT+02:00 erjan altena <er...@gmail.com>:
> Nice to see that the patch is merged so soon.
>
> The -pthread on linux is similar to "-lpthread -D_REENTRANT". The latter is
> used by standard-C headers to make
> functions thread safe. As an example it makes the errno variable thread
> safe. I think it should be set when
> using pthreads.
>
> Regards,
> Erjan
>
> On Mon, Sep 29, 2014 at 8:57 AM, Alexander Broekhuis <
> a.broekhuis@gmail.com>
> wrote:
>
> > Thanks for creating an issue.
> >
> > I've been looking at the patch a bit, and noticed you enabled all
> warnings.
> > While I think this is a good idea, I've created a separate issue for it
> > [1].
> > Normally I prefer patches for 1 module, yours included a few fixed for
> > files not related to the echo example as well. I will commit those fixes
> > under the issue at [1].
> >
> > Is the "-pthread" needed on Linux? I haven't had any problems on OSX
> > without it, and do get a warning when using it. If it is needed an extra
> > check is needed to not use it on OSX, but for other UNIXes.
> >
> > Ps: You also included a patch file in the patch, I assume this was not
> > intentional, and just ignored the file.
> > Pps: I also updated the ident of the echo_client to a better suited text
> > (sorry, couldn't resist :)).
> >
> >
> > [1]: https://issues.apache.org/jira/browse/CELIX-156
> >
> >
> > 2014-09-28 22:04 GMT+02:00 Erjan Altena (JIRA) <ji...@apache.org>:
> >
> > >
> > > [
> > >
> >
> https://issues.apache.org/jira/browse/CELIX-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > ]
> > >
> > > Erjan Altena updated CELIX-154:
> > > -------------------------------
> > > Description:
> > > The echo echo-example was not working. I made a fix. It does not rely
> > any
> > > more an apr but on posix threads.
> > >
> > > I added also a small error message fix and enabled compiler warnings.
> > >
> > > The attached patch is based on the current trunk. If you lke to have
> it
> > > in another format please let me know.
> > >
> > > was:
> > > The echo echo-example was not working. I made a fix. It does not rely
> > any
> > > more an apr but on posix threads.
> > >
> > > I added also a small error message fix and enabled compiler warnings.
> > >
> > > The fix is a patcn on current trunk. If you lke to have it in another
> > > format please let me know.
> > >
> > >
> > > > echo exampe not working
> > > > -----------------------
> > > >
> > > > Key: CELIX-154
> > > > URL: https://issues.apache.org/jira/browse/CELIX-154
> > > > Project: Celix
> > > > Issue Type: Bug
> > > > Components: Examples
> > > > Affects Versions: next-incubating
> > > > Environment: linux 32 bit
> > > > Reporter: Erjan Altena
> > > > Priority: Minor
> > > > Fix For: next-incubating
> > > >
> > > > Attachments: echo_example_fix.patch
> > > >
> > > >
> > > > The echo echo-example was not working. I made a fix. It does not
> rely
> > > any more an apr but on posix threads.
> > > > I added also a small error message fix and enabled compiler warnings.
> > > > The attached patch is based on the current trunk. If you lke to have
> > it
> > > in another format please let me know.
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian JIRA
> > > (v6.3.4#6332)
> > >
> >
> >
> >
> > --
> > Met vriendelijke groet,
> >
> > Alexander Broekhuis
> >
>
>
>
> --
> -------------------------------------------------------
> Erjan Altena
>
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [jira] [Updated] (CELIX-154) echo exampe not working
Posted by erjan altena <er...@gmail.com>.
Nice to see that the patch is merged so soon.
The -pthread on linux is similar to "-lpthread -D_REENTRANT". The latter is
used by standard-C headers to make
functions thread safe. As an example it makes the errno variable thread
safe. I think it should be set when
using pthreads.
Regards,
Erjan
On Mon, Sep 29, 2014 at 8:57 AM, Alexander Broekhuis <a....@gmail.com>
wrote:
> Thanks for creating an issue.
>
> I've been looking at the patch a bit, and noticed you enabled all warnings.
> While I think this is a good idea, I've created a separate issue for it
> [1].
> Normally I prefer patches for 1 module, yours included a few fixed for
> files not related to the echo example as well. I will commit those fixes
> under the issue at [1].
>
> Is the "-pthread" needed on Linux? I haven't had any problems on OSX
> without it, and do get a warning when using it. If it is needed an extra
> check is needed to not use it on OSX, but for other UNIXes.
>
> Ps: You also included a patch file in the patch, I assume this was not
> intentional, and just ignored the file.
> Pps: I also updated the ident of the echo_client to a better suited text
> (sorry, couldn't resist :)).
>
>
> [1]: https://issues.apache.org/jira/browse/CELIX-156
>
>
> 2014-09-28 22:04 GMT+02:00 Erjan Altena (JIRA) <ji...@apache.org>:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/CELIX-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Erjan Altena updated CELIX-154:
> > -------------------------------
> > Description:
> > The echo echo-example was not working. I made a fix. It does not rely
> any
> > more an apr but on posix threads.
> >
> > I added also a small error message fix and enabled compiler warnings.
> >
> > The attached patch is based on the current trunk. If you lke to have it
> > in another format please let me know.
> >
> > was:
> > The echo echo-example was not working. I made a fix. It does not rely
> any
> > more an apr but on posix threads.
> >
> > I added also a small error message fix and enabled compiler warnings.
> >
> > The fix is a patcn on current trunk. If you lke to have it in another
> > format please let me know.
> >
> >
> > > echo exampe not working
> > > -----------------------
> > >
> > > Key: CELIX-154
> > > URL: https://issues.apache.org/jira/browse/CELIX-154
> > > Project: Celix
> > > Issue Type: Bug
> > > Components: Examples
> > > Affects Versions: next-incubating
> > > Environment: linux 32 bit
> > > Reporter: Erjan Altena
> > > Priority: Minor
> > > Fix For: next-incubating
> > >
> > > Attachments: echo_example_fix.patch
> > >
> > >
> > > The echo echo-example was not working. I made a fix. It does not rely
> > any more an apr but on posix threads.
> > > I added also a small error message fix and enabled compiler warnings.
> > > The attached patch is based on the current trunk. If you lke to have
> it
> > in another format please let me know.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
> >
>
>
>
> --
> Met vriendelijke groet,
>
> Alexander Broekhuis
>
--
-------------------------------------------------------
Erjan Altena