[GitHub] [drill] vvysotskyi commented on a diff in pull request #2573: DRILL-8248: Fix http_request for several rows

[GitBox <gi...@apache.org>]

vvysotskyi commented on code in PR #2573:
URL: https://github.com/apache/drill/pull/2573#discussion_r897117091


##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/loader/SingleElementIterator.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.easy.json.loader;
+
+import java.util.Iterator;
+
+/**
+ * It allows setting current value in the iterator and cane be used once after {@link #next} call

Review Comment:
   ```suggestion
    * It allows setting the current value in the iterator and can be used once after {@link #next} call
   ```



##########
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##########
@@ -110,7 +110,7 @@ protected IterOutcome doWork() {
     memoryManager.update();
 
     if (first && incomingRecordCount == 0) {
-      if (complexWriters != null || rsLoader != null ) {
+      if ((complexWriters != null && !complexWriters.isEmpty()) || rsLoader != null ) {

Review Comment:
   `(complexWriters != null && !complexWriters.isEmpty())` -> `!CollectionUtils.isEmpty(complexWriters)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org