You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josh-fell (via GitHub)" <gi...@apache.org> on 2023/03/10 21:48:01 UTC
[GitHub] [airflow] josh-fell opened a new pull request, #30031: Clarify optional parameters in Airbyte docstrings
josh-fell opened a new pull request, #30031:
URL: https://github.com/apache/airflow/pull/30031
There were a few inconsistencies in the Airbyte module docstrings which called out required parameters even though those parameters had default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #30031: Clarify optional parameters in Airbyte docstrings
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #30031:
URL: https://github.com/apache/airflow/pull/30031#discussion_r1132917248
##########
airflow/providers/airbyte/operators/airbyte.py:
##########
@@ -53,10 +54,10 @@ def __init__(
self,
connection_id: str,
airbyte_conn_id: str = "airbyte_default",
- asynchronous: bool | None = False,
+ asynchronous: bool = False,
api_version: str = "v1",
wait_seconds: float = 3,
- timeout: float | None = 3600,
+ timeout: float = 3600,
Review Comment:
Cleaned up some typing as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30031: Clarify optional parameters in Airbyte docstrings
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30031:
URL: https://github.com/apache/airflow/pull/30031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org