You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/01/02 14:15:26 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3990: HBASE-26397 Display the excluded datanodes on regionserver UI

Apache9 commented on a change in pull request #3990:
URL: https://github.com/apache/hbase/pull/3990#discussion_r777215855



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
##########
@@ -398,6 +403,17 @@ public long getWALFileSize() {
     return walFileSize;
   }
 
+  @Override
+  public List<String> getWALExcludeDNs() {
+    if (excludeDatanodeManager == null) {
+      return new ArrayList<>();

Review comment:
       Why must return ArrayList here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org