You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "renovate-bot (via GitHub)" <gi...@apache.org> on 2026/06/09 08:16:46 UTC
[PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
renovate-bot opened a new pull request, #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636
This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [org.apache.felix:org.apache.felix.http.jetty12](https://felix.apache.org/) ([source](https://gitbox.apache.org/repos/asf?p=felix-dev.git)) | `1.2.0` → `2.0.0` |  |  |
---
### Configuration
📅 **Schedule**: (UTC)
- Branch creation
- At any time (no schedule defined)
- Automerge
- At any time (no schedule defined)
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
â™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/sling-org-apache-sling-starter).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDkuNCIsInVwZGF0ZWRJblZlciI6IjQzLjIwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update dependency org.apache.felix:org.apache.felix.http.jetty12 to v2 [sling-org-apache-sling-starter]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert merged PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4763692320
> I do not know yet, did not look into the root cause. While it's very likely that we should adjust the tests it might be something that we want to configure away or maybe even a bug in Felix HTTP, overwriting the charset.
@rombert From what I can suss out, the sudden appearance of the ;charset=utf-8 suffix is the direct result of a major architectural rewrite introduced in Jetty 12. Prior versions of Jetty did not automatically append the suffix to your Content-Type header, but Jetty 12.1 does it by default due to a foundational shift in how the container prioritizes web standards.
The change comes down to a major shift in the core [encoding.properties](https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-core/jetty-http/src/main/resources/org/eclipse/jetty/http/encoding.properties) modernization. In older versions of Jetty, the internal encoding.properties configuration file favored legacy rules. However, starting with the newer Jetty 12 core architecture, the engineering team modernized the default file mapping to align with modern HTTP and HTML5 standards. They explicitly changed the mapping for HTML to text/html=utf-8 inside the core engine. Because it is registered as an inferred encoding type, Jetty’s core HTTP layer is now designed to actively intercept any response set to text/html and automatically stamp ;charset=utf-8 onto the outgoing HTTP header if no other encoding was explicitly specified.
So updating the tests to compensate seems like the right solution to me as the response header doesn't seem to be incorrect.
Alternatively, API calls could programmatically change back to the way it was before with something like this:
```
// Processes bytes as UTF-8 internally, but keeps the header strictly as "text/html"
context.getMimeTypes().addAssumed("text/xml", "UTF-8");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4657856717
```
[ERROR] Failures:
[ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
Expected: "text/xml"
but: was "text/xml;charset=utf-8"
[ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
Expected: "text/xml"
but: was "text/xml;charset=utf-8"
[ERROR] HeadServletTest.htmlHead:91->assertCommonHeaders:65->assertResponseHeader:58 Expected regexp text/html for header Content-Type, header value is text/html;charset=utf-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4768178429
@enapps-enorman - I agree that updating the tests makes more sense that trying to keep the header value unchanged ; no sense fighting against upstream here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4712997470
> ```
> [ERROR] Failures:
> [ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
> Expected: "text/xml"
> but: was "text/xml;charset=utf-8"
> [ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
> Expected: "text/xml"
> but: was "text/xml;charset=utf-8"
> [ERROR] HeadServletTest.htmlHead:91->assertCommonHeaders:65->assertResponseHeader:58 Expected regexp text/html for header Content-Type, header value is text/html;charset=utf-8
> ```
I assume the solution here is to fix the test assertions to handle the presence of a charset suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http (major) [sling-org-apache-sling-starter]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4778654639
Both PRs look good, thanks for taking this up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http to v2 [sling-org-apache-sling-starter]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4716317734
> > ```
> > [ERROR] Failures:
> > [ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
> > Expected: "text/xml"
> > but: was "text/xml;charset=utf-8"
> > [ERROR] SmokeIT.ensureRepositoryIsStarted:201 Content-Type header
> > Expected: "text/xml"
> > but: was "text/xml;charset=utf-8"
> > [ERROR] HeadServletTest.htmlHead:91->assertCommonHeaders:65->assertResponseHeader:58 Expected regexp text/html for header Content-Type, header value is text/html;charset=utf-8
> > ```
>
> I assume the solution here is to fix the test assertions to handle the presence of a charset suffix?
I do not know yet, did not look into the root cause. While it's very likely that we should adjust the tests it might be something that we want to configure away or maybe even a bug in Felix HTTP, overwriting the charset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): update apache felix http (major) [sling-org-apache-sling-starter]
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on PR #636:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/636#issuecomment-4771846292
These 2 PRs update the tests if you wish to review:
1. https://github.com/apache/sling-org-apache-sling-starter-integration-tests/pull/49
2. https://github.com/apache/sling-org-apache-sling-starter/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org