You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/07/05 21:54:27 UTC
Review Request 67837: Update AtlasAdminClient to accept credentials
via cmdline
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67837/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2780
https://issues.apache.org/jira/browse/ATLAS-2780
Repository: atlas
Description
-------
See JIRA
Diffs
-----
client/client-v1/src/main/java/org/apache/atlas/AtlasAdminClient.java f334f6c69
intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java af32afccc
Diff: https://reviews.apache.org/r/67837/diff/1/
Testing
-------
Verified using the driver script and a direct run of AtlasAdminClient.main
Thanks,
Apoorv Naik
Re: Review Request 67837: Update AtlasAdminClient to accept
credentials via cmdline
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67837/#review205779
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On July 5, 2018, 2:59 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67837/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:59 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2780
> https://issues.apache.org/jira/browse/ATLAS-2780
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> client/client-v1/src/main/java/org/apache/atlas/AtlasAdminClient.java f334f6c69
> intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java af32afccc
>
>
> Diff: https://reviews.apache.org/r/67837/diff/1/
>
>
> Testing
> -------
>
> Verified using the driver script and a direct run of AtlasAdminClient.main
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67837: Update AtlasAdminClient to accept
credentials via cmdline
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67837/#review205778
-----------------------------------------------------------
client/client-v1/src/main/java/org/apache/atlas/AtlasAdminClient.java
Lines 121 (patched)
<https://reviews.apache.org/r/67837/#comment288681>
handle null for 'value' and 'basicAuthUsernamePassword'
- Sarath Subramanian
On July 5, 2018, 2:59 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67837/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:59 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2780
> https://issues.apache.org/jira/browse/ATLAS-2780
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> client/client-v1/src/main/java/org/apache/atlas/AtlasAdminClient.java f334f6c69
> intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java af32afccc
>
>
> Diff: https://reviews.apache.org/r/67837/diff/1/
>
>
> Testing
> -------
>
> Verified using the driver script and a direct run of AtlasAdminClient.main
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67837: Update AtlasAdminClient to accept
credentials via cmdline
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67837/
-----------------------------------------------------------
(Updated July 5, 2018, 9:59 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2780
https://issues.apache.org/jira/browse/ATLAS-2780
Repository: atlas
Description
-------
See JIRA
Diffs
-----
client/client-v1/src/main/java/org/apache/atlas/AtlasAdminClient.java f334f6c69
intg/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java af32afccc
Diff: https://reviews.apache.org/r/67837/diff/1/
Testing
-------
Verified using the driver script and a direct run of AtlasAdminClient.main
Thanks,
Apoorv Naik