You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "heguanhui (via GitHub)" <gi...@apache.org> on 2026/05/28 17:10:17 UTC
[PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
heguanhui opened a new pull request, #63864:
URL: https://github.com/apache/doris/pull/63864
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: The `SHOW TRASH` command only displays aggregated `TrashUsedCapacity` per backend, providing very limited information for troubleshooting disk space issues. Users cannot see per-disk trash details, trash file counts, or disk capacity/availability. Additionally, `SHOW TRASH ON` has a parser bug where the backend parameter is silently discarded.
**Changes:**
1. **Thrift**: Added `trash_file_num`, `disk_capacity`, `available_capacity` as optional fields to `TDiskTrashInfo`
2. **BE**:
- Added `trash_file_num` to `DataDirInfo`; `DataDir` counts trash subdirectories in `update_trash_capacity()`
- `BackendService::get_disk_trash_used_capacity()` now populates the three new fields
3. **FE**:
- `TrashProcDir` now calls `getDiskTrashUsedCapacity()` instead of `getTrashUsedCapacity()`, expanding from 3 columns to 8 columns: `BackendId | Backend | RootPath | State | TrashUsedCapacity | TrashFileNum | DiskCapacity | AvailableCapacity`
- `TrashProcNode` adapted for 6 columns per disk
- `ShowTrashCommand` column width adjusted from `varchar(30)` to `varchar(60)`
4. **Bug fix**: Fixed `LogicalPlanBuilder.visitShowTrash()` where `SHOW TRASH ON` backend parameter was silently discarded
**Before:**
```
+----------+-----------+------------------+
| BackendId | Backend | TrashUsedCapacity |
+----------+-----------+------------------+
| 10001 | 10.0.0.1 | 1024 |
+----------+-----------+------------------+
```
**After:**
```
+----------+-----------+----------+-------+------------------+-------------+--------------+--------------------+
| BackendId | Backend | RootPath | State | TrashUsedCapacity | TrashFileNum | DiskCapacity | AvailableCapacity |
+----------+-----------+----------+-------+------------------+-------------+--------------+--------------------+
| 10001 | 10.0.0.1 | /data1 | OK | 512 | 3 | 107374182400 | 53687091200 |
| 10001 | 10.0.0.1 | /data2 | OK | 512 | 2 | 107374182400 | 53687091200 |
+----------+-----------+----------+-------+------------------+-------------+--------------+--------------------+
```
### Release note
SHOW TRASH now displays per-disk details including RootPath, State, TrashFileNum, DiskCapacity, and AvailableCapacity. Fixed SHOW TRASH ON parser bug.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test
- [ ] No need to test or manual test. Explain why:
- Behavior changed:
- [ ] No.
- [x] Yes. SHOW TRASH output changes from 3 columns (BackendId, Backend, TrashUsedCapacity) to 8 columns (BackendId, Backend, RootPath, State, TrashUsedCapacity, TrashFileNum, DiskCapacity, AvailableCapacity)
- Does this need documentation?
- [ ] No.
- [x] Yes. <!-- Will submit doc PR separately -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920015257
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/275b29c47c6abaf837b5ba643a1b850875d2f118_275b29c47c6abaf837b5ba643a1b850875d2f118_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/275b29c47c6abaf837b5ba643a1b850875d2f118_275b29c47c6abaf837b5ba643a1b850875d2f118_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 77.39% (1896/2450) |
| Line Coverage | 64.42% (34053/52862) |
| Region Coverage | 64.83% (17524/27032) |
| Branch Coverage | 54.01% (9392/17390) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4567724189
<details>
<summary>TPC-H: <b>Total hot run time: 31846 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b50517e8508df1429d7b77edddee3a33d14aa717, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17632 4111 4142 4111
q2 q3 11005 1487 827 827
q4 4754 480 344 344
q5 10619 2332 2170 2170
q6 398 186 141 141
q7 969 816 646 646
q8 9655 1805 1616 1616
q9 7252 5033 5042 5033
q10 6549 2283 1882 1882
q11 447 282 246 246
q12 694 437 299 299
q13 18183 3413 2826 2826
q14 273 258 240 240
q15 q16 852 777 708 708
q17 931 960 976 960
q18 6871 5760 5610 5610
q19 1164 1238 1103 1103
q20 519 419 274 274
q21 5738 2693 2499 2499
q22 433 358 311 311
Total cold run time: 104938 ms
Total hot run time: 31846 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4545 4500 4492 4492
q2 q3 4576 4974 4325 4325
q4 2225 2241 1382 1382
q5 4565 5108 5148 5108
q6 263 207 151 151
q7 1995 1845 1611 1611
q8 2665 2314 2330 2314
q9 8178 8010 8220 8010
q10 4828 4759 4330 4330
q11 636 453 435 435
q12 756 751 556 556
q13 3418 3695 3049 3049
q14 318 305 271 271
q15 q16 724 771 644 644
q17 1397 1344 1379 1344
q18 7887 7217 6886 6886
q19 1122 1099 1125 1099
q20 2215 2200 1937 1937
q21 5322 4766 4661 4661
q22 523 460 404 404
Total cold run time: 58158 ms
Total hot run time: 53009 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "yx-keith (via GitHub)" <gi...@apache.org>.
yx-keith commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4899109142
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920916009
# BE UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/275b29c47c6abaf837b5ba643a1b850875d2f118_275b29c47c6abaf837b5ba643a1b850875d2f118/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/275b29c47c6abaf837b5ba643a1b850875d2f118_275b29c47c6abaf837b5ba643a1b850875d2f118/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.54% (23212/41051) |
| Line Coverage | 40.10% (225262/561699) |
| Region Coverage | 36.05% (177889/493469) |
| Branch Coverage | 37.10% (79070/213111) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3332247552
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTrashCommand.java:
##########
@@ -65,7 +65,7 @@ public String getBackend() {
public ShowResultSetMetaData getMetaData() {
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();
for (String title : TrashProcDir.TITLE_NAMES) {
- builder.addColumn(new Column(title, ScalarType.createVarchar(30)));
+ builder.addColumn(new Column(title, ScalarType.createVarchar(60)));
Review Comment:
maybe change to string is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4590387113
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4924261114
# BE UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.61% (23241/41058) |
| Line Coverage | 40.16% (225586/561779) |
| Region Coverage | 36.05% (178022/493755) |
| Branch Coverage | 37.13% (79134/213133) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4941309798
# FE UT Coverage Report
Increment line coverage ` 78.26% (54/69)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_75d67ba634314ab4500b5ff667f64ec22b6e86ce/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_75d67ba634314ab4500b5ff667f64ec22b6e86ce/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4925177880
# BE Regression && UT Coverage Report
Increment line coverage `80.00% (12/15)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 74.82% (29982/40072) |
| Line Coverage | 58.91% (329055/558547) |
| Region Coverage | 55.84% (276854/495831) |
| Branch Coverage | 57.06% (121752/213368) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4942674192
<details>
<summary>ClickBench: <b>Total hot run time: 25.11 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 75d67ba634314ab4500b5ff667f64ec22b6e86ce, data reload: false
query1 0.01 0.01 0.00
query2 0.09 0.05 0.05
query3 0.25 0.14 0.13
query4 1.61 0.15 0.15
query5 0.25 0.23 0.23
query6 1.23 1.09 1.09
query7 0.04 0.01 0.00
query8 0.06 0.04 0.04
query9 0.37 0.32 0.31
query10 0.55 0.55 0.55
query11 0.20 0.14 0.15
query12 0.19 0.15 0.14
query13 0.47 0.47 0.48
query14 1.02 1.00 1.00
query15 0.62 0.60 0.60
query16 0.31 0.34 0.31
query17 1.11 1.05 1.14
query18 0.23 0.21 0.21
query19 2.03 1.95 1.98
query20 0.01 0.01 0.01
query21 15.54 0.22 0.14
query22 4.70 0.05 0.05
query23 16.14 0.31 0.12
query24 2.98 0.41 0.32
query25 0.12 0.05 0.04
query26 0.71 0.20 0.15
query27 0.04 0.05 0.03
query28 3.54 0.95 0.54
query29 12.50 4.09 3.23
query30 0.27 0.16 0.15
query31 2.77 0.63 0.32
query32 3.22 0.60 0.50
query33 3.16 3.26 3.23
query34 15.52 4.26 3.53
query35 3.53 3.52 3.53
query36 0.56 0.45 0.45
query37 0.08 0.06 0.07
query38 0.05 0.04 0.03
query39 0.04 0.03 0.02
query40 0.18 0.16 0.16
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.03 0.04
Total cold run time: 96.47 s
Total hot run time: 25.11 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3540093827
##########
regression-test/suites/query_p0/ddl/show_trash/test_nereids_trash.groovy:
##########
@@ -20,6 +20,32 @@ suite("show_trash_nereids") {
checkNereidsExecute("""show trash;""")
checkNereidsExecute("""show trash on "127.0.0.1:9050";""")
Review Comment:
Regarding the parser bug you identified (the ON clause being silently ignored and falling back to all backends), I completely agree. This parser bug has actually been fundamentally fixed in the related PR [#63860](https://github.com/apache/doris/pull/63860). That PR addresses:
The missing return statement in LogicalPlanBuilder.visitShowTrash() that caused the ON clause to be ignored.
The syntax inconsistency between SHOW TRASH ON and ADMIN CLEAN TRASH ON, now supporting multiple backends with parenthesized comma-separated list, e.g., SHOW TRASH ON ("be1:9050", "be2:9050").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4590415378
cloud p0 case `test_show_charset_auth.groovy` failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900417937
# BE Regression && UT Coverage Report
Increment line coverage `80.00% (12/15)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 74.64% (29857/40000) |
| Line Coverage | 58.58% (326369/557125) |
| Region Coverage | 55.47% (273972/493931) |
| Branch Coverage | 56.69% (120578/212709) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900468644
# FE Regression Coverage Report
Increment line coverage ` 7.09% (42/592)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "yx-keith (via GitHub)" <gi...@apache.org>.
yx-keith commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4931620241
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4942612727
<details>
<summary>TPC-DS: <b>Total hot run time: 180661 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 75d67ba634314ab4500b5ff667f64ec22b6e86ce, data reload: false
query5 4346 640 498 498
query6 474 229 208 208
query7 4933 631 354 354
query8 342 213 178 178
query9 8783 4108 4114 4108
query10 489 359 296 296
query11 5950 2354 2169 2169
query12 153 105 100 100
query13 1264 622 459 459
query14 6240 5386 5003 5003
query14_1 4385 4357 4317 4317
query15 216 209 190 190
query16 1030 474 423 423
query17 1099 712 578 578
query18 2494 486 337 337
query19 209 189 148 148
query20 118 107 107 107
query21 227 156 134 134
query22 13567 13709 13395 13395
query23 17501 16664 16169 16169
query23_1 16296 16245 16285 16245
query24 7538 1839 1286 1286
query24_1 1324 1313 1311 1311
query25 553 438 382 382
query26 1340 351 207 207
query27 2589 611 404 404
query28 4490 1993 2006 1993
query29 1071 620 515 515
query30 338 273 222 222
query31 1133 1115 977 977
query32 118 66 65 65
query33 547 347 260 260
query34 1177 1178 652 652
query35 781 824 671 671
query36 1384 1372 1218 1218
query37 159 110 95 95
query38 1894 1700 1652 1652
query39 928 932 904 904
query39_1 888 875 866 866
query40 251 168 144 144
query41 70 75 69 69
query42 132 93 91 91
query43 340 338 294 294
query44 1509 795 786 786
query45 204 186 179 179
query46 1115 1288 752 752
query47 2373 2317 2216 2216
query48 407 427 304 304
query49 587 421 321 321
query50 1033 439 346 346
query51 10623 10541 10770 10541
query52 92 92 76 76
query53 263 285 204 204
query54 290 260 233 233
query55 73 74 67 67
query56 297 309 307 307
query57 1461 1400 1331 1331
query58 280 263 253 253
query59 1628 1738 1451 1451
query60 302 279 256 256
query61 155 144 150 144
query62 695 658 589 589
query63 256 208 207 207
query64 2849 1073 945 945
query65 4866 4763 4832 4763
query66 1805 523 381 381
query67 29625 29492 29400 29400
query68 3127 1559 985 985
query69 406 317 279 279
query70 1074 966 969 966
query71 349 319 309 309
query72 3109 2543 2406 2406
query73 836 765 429 429
query74 5147 4936 4733 4733
query75 2665 2606 2212 2212
query76 2339 1274 808 808
query77 370 399 297 297
query78 12294 12238 11703 11703
query79 1198 1194 752 752
query80 597 565 454 454
query81 452 330 280 280
query82 239 159 124 124
query83 325 332 301 301
query84 289 156 130 130
query85 905 615 542 542
query86 342 315 261 261
query87 1834 1820 1768 1768
query88 3772 2833 2795 2795
query89 439 407 364 364
query90 2199 203 200 200
query91 206 194 166 166
query92 64 66 58 58
query93 1550 1577 981 981
query94 556 375 354 354
query95 794 546 490 490
query96 1114 866 362 362
query97 2706 2725 2569 2569
query98 212 210 208 208
query99 1200 1187 1026 1026
Total cold run time: 265032 ms
Total hot run time: 180661 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3556187275
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTrashCommand.java:
##########
@@ -42,6 +43,17 @@
* show trash command
*/
public class ShowTrashCommand extends ShowCommand {
+ private static final ShowResultSetMetaData META_DATA = ShowResultSetMetaData.builder()
+ .addColumn(new Column("BackendId", ScalarType.createType(PrimitiveType.BIGINT)))
+ .addColumn(new Column("Backend", ScalarType.createStringType()))
+ .addColumn(new Column("RootPath", ScalarType.createStringType()))
+ .addColumn(new Column("State", ScalarType.createStringType()))
+ .addColumn(new Column("TrashUsedCapacity", ScalarType.createStringType()))
Review Comment:
This column cannot safely be `BIGINT` while the new fallback path can emit `"N/A"` for the same slot. When `getDiskTrashUsedCapacity()` is unavailable, `TrashProcDir.addFallbackRow()` fills `TrashFileNum` with `"N/A"`; if the client executes `SHOW TRASH` through the prepared-statement path, `StmtExecutor.sendBinaryResultRow()` sees the BIGINT metadata and calls `Long.parseLong(item)`, so the diagnostic fallback row fails to serialize instead of being returned. Please keep the metadata and all row values consistent, e.g. make this column a string like the other placeholder-capable diagnostic columns or emit a numeric/null value on fallback.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java:
##########
@@ -99,20 +102,61 @@ public static void getTrashInfo(List<Backend> backends, List<List<String>> infos
}
}
- List<String> backendInfo = new ArrayList<>();
- backendInfo.add(String.valueOf(backend.getId()));
- backendInfo.add(NetUtils.getHostPortInAccessibleFormat(backend.getHost(), backend.getHeartbeatPort()));
- if (trashUsedCapacityB != null) {
+ if (CollectionUtils.isEmpty(diskTrashInfos)) {
+ addFallbackRow(backend, infos);
+ continue;
+ }
+ for (TDiskTrashInfo diskTrashInfo : diskTrashInfos) {
+ List<String> rowInfo = new ArrayList<>();
+ rowInfo.add(String.valueOf(backend.getId()));
+ rowInfo.add(NetUtils.getHostPortInAccessibleFormat(backend.getHost(), backend.getHeartbeatPort()));
+ rowInfo.add(diskTrashInfo.getRootPath());
+ rowInfo.add(diskTrashInfo.getState());
+
+ long trashUsedCapacityB = diskTrashInfo.getTrashUsedCapacity();
Pair<Double, String> trashUsedCapacity = DebugUtil.getByteUint(trashUsedCapacityB);
- backendInfo.add(DebugUtil.DECIMAL_FORMAT_SCALE_3.format(trashUsedCapacity.first) + " "
+ rowInfo.add(DebugUtil.DECIMAL_FORMAT_SCALE_3.format(trashUsedCapacity.first) + " "
+ trashUsedCapacity.second);
- } else {
Review Comment:
Treating an unset `trash_file_num` as `"0"` makes mixed-version results misleading. Because field 4 is newly added and optional, a new FE can talk to an old BE that returns valid per-disk trash rows without this field set; this code will show every such disk as having exactly zero trash files even if the BE simply did not report the count. The other new optional fields are rendered as unknown/empty when unset, and `TrashProcNode` has the same `"0"` fallback, so please handle `trash_file_num` as unknown too and update the compatibility test that currently locks in `"0"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4568747523
# FE Regression Coverage Report
Increment line coverage ` 69.57% (32/46)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_b50517e8508df1429d7b77edddee3a33d14aa717_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_b50517e8508df1429d7b77edddee3a33d14aa717_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4566685627
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3540091056
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java:
##########
@@ -99,17 +101,43 @@ public static void getTrashInfo(List<Backend> backends, List<List<String>> infos
}
}
- List<String> backendInfo = new ArrayList<>();
- backendInfo.add(String.valueOf(backend.getId()));
- backendInfo.add(NetUtils.getHostPortInAccessibleFormat(backend.getHost(), backend.getHeartbeatPort()));
- if (trashUsedCapacityB != null) {
+ if (diskTrashInfos == null) {
Review Comment:
I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884202643
> cloud p0 case `test_show_charset_auth.groovy` failed
I already fix this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884298434
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/90ccbf08f63b932fb3e782b927e234b3a604d206_90ccbf08f63b932fb3e782b927e234b3a604d206_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/90ccbf08f63b932fb3e782b927e234b3a604d206_90ccbf08f63b932fb3e782b927e234b3a604d206_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 77.39% (1896/2450) |
| Line Coverage | 64.45% (34072/52862) |
| Region Coverage | 64.85% (17529/27032) |
| Branch Coverage | 54.04% (9398/17390) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920562518
<details>
<summary>ClickBench: <b>Total hot run time: 25.84 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 275b29c47c6abaf837b5ba643a1b850875d2f118, data reload: false
query1 0.00 0.00 0.00
query2 0.15 0.10 0.08
query3 0.38 0.24 0.25
query4 1.61 0.26 0.25
query5 0.33 0.32 0.33
query6 1.15 0.69 0.68
query7 0.04 0.01 0.00
query8 0.09 0.07 0.08
query9 0.52 0.38 0.37
query10 0.60 0.59 0.60
query11 0.32 0.19 0.20
query12 0.32 0.19 0.19
query13 0.52 0.53 0.53
query14 0.93 0.92 0.92
query15 0.68 0.60 0.60
query16 0.40 0.39 0.39
query17 1.04 1.06 1.01
query18 0.32 0.30 0.32
query19 1.96 1.83 1.79
query20 0.02 0.02 0.01
query21 15.39 0.37 0.33
query22 4.91 0.13 0.14
query23 15.76 0.51 0.30
query24 2.35 0.62 0.45
query25 0.16 0.10 0.10
query26 0.74 0.28 0.21
query27 0.10 0.11 0.09
query28 3.36 0.98 0.53
query29 12.46 4.36 3.34
query30 0.38 0.27 0.25
query31 2.76 0.64 0.35
query32 3.23 0.61 0.47
query33 2.92 2.92 3.04
query34 15.67 4.13 3.43
query35 3.29 3.30 3.32
query36 0.67 0.54 0.52
query37 0.12 0.10 0.10
query38 0.09 0.07 0.07
query39 0.08 0.06 0.06
query40 0.21 0.18 0.17
query41 0.13 0.08 0.07
query42 0.09 0.06 0.06
query43 0.07 0.07 0.06
Total cold run time: 96.32 s
Total hot run time: 25.84 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900020738
# BE UT Coverage Report
Increment line coverage `100.00% (12/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/41fc280859aa4441500d68d0f05ac7fc38127931_41fc280859aa4441500d68d0f05ac7fc38127931/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/41fc280859aa4441500d68d0f05ac7fc38127931_41fc280859aa4441500d68d0f05ac7fc38127931/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 56.53% (23163/40973) |
| Line Coverage | 40.09% (224641/560322) |
| Region Coverage | 36.08% (177465/491838) |
| Branch Coverage | 37.11% (78854/212474) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4590368898
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4899545888
# FE UT Coverage Report
Increment line coverage ` 73.21% (41/56)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_41fc280859aa4441500d68d0f05ac7fc38127931/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884419247
# FE UT Coverage Report
Increment line coverage ` 73.21% (41/56)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_90ccbf08f63b932fb3e782b927e234b3a604d206/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_90ccbf08f63b932fb3e782b927e234b3a604d206/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4931583024
run cloud_p0 regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4931590187
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4942541938
<details>
<summary>TPC-H: <b>Total hot run time: 29802 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 75d67ba634314ab4500b5ff667f64ec22b6e86ce, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17729 4146 4058 4058
q2 2013 359 209 209
q3 10232 1432 823 823
q4 4735 475 339 339
q5 7758 851 594 594
q6 236 168 138 138
q7 791 844 629 629
q8 10420 1613 1704 1613
q9 5844 4419 4478 4419
q10 6864 1817 1522 1522
q11 518 351 312 312
q12 786 555 432 432
q13 18195 3898 2805 2805
q14 274 256 243 243
q15 q16 809 788 712 712
q17 1007 903 1046 903
q18 6879 5760 5732 5732
q19 1245 1140 1050 1050
q20 771 642 536 536
q21 5879 2695 2434 2434
q22 441 363 299 299
Total cold run time: 103426 ms
Total hot run time: 29802 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4423 4286 4345 4286
q2 294 322 220 220
q3 4583 4950 4409 4409
q4 2054 2169 1355 1355
q5 4409 4281 4337 4281
q6 227 185 129 129
q7 2404 1959 1687 1687
q8 2497 2178 2159 2159
q9 8383 7864 7901 7864
q10 4781 4657 4260 4260
q11 588 410 416 410
q12 765 782 551 551
q13 3238 3672 2935 2935
q14 294 321 275 275
q15 q16 702 738 633 633
q17 1376 1453 1329 1329
q18 7908 7334 7172 7172
q19 1112 1061 1105 1061
q20 2215 2218 1926 1926
q21 5225 4591 4386 4386
q22 528 438 396 396
Total cold run time: 58006 ms
Total hot run time: 51724 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4940236897
run check_coverage_fe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4940693055
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4595692785
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8930941acb6596cd5616ecdace4a5d82184fdc18_8930941acb6596cd5616ecdace4a5d82184fdc18_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8930941acb6596cd5616ecdace4a5d82184fdc18_8930941acb6596cd5616ecdace4a5d82184fdc18_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.34% (1906/2433) |
| Line Coverage | 64.76% (33979/52468) |
| Region Coverage | 65.32% (17526/26833) |
| Branch Coverage | 53.95% (9296/17230) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4590387373
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4595432564
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4923579179
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920234596
# FE UT Coverage Report
Increment line coverage ` 78.26% (54/69)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_275b29c47c6abaf837b5ba643a1b850875d2f118/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_275b29c47c6abaf837b5ba643a1b850875d2f118/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920539876
<details>
<summary>TPC-DS: <b>Total hot run time: 180566 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 275b29c47c6abaf837b5ba643a1b850875d2f118, data reload: false
query5 4319 628 491 491
query6 453 234 212 212
query7 4877 590 338 338
query8 334 190 171 171
query9 8770 4127 4084 4084
query10 481 340 305 305
query11 5956 2379 2135 2135
query12 170 113 110 110
query13 1357 608 448 448
query14 6307 5287 4970 4970
query14_1 4315 4328 4431 4328
query15 223 204 185 185
query16 1054 472 485 472
query17 1148 737 593 593
query18 2656 499 358 358
query19 214 197 152 152
query20 119 111 107 107
query21 229 154 135 135
query22 13727 13533 13395 13395
query23 17297 16537 16215 16215
query23_1 16215 16342 16236 16236
query24 7632 1814 1317 1317
query24_1 1288 1332 1327 1327
query25 571 484 398 398
query26 1329 371 252 252
query27 2490 595 376 376
query28 4501 2026 2014 2014
query29 1099 605 485 485
query30 338 262 228 228
query31 1109 1096 978 978
query32 109 60 58 58
query33 531 314 240 240
query34 1170 1153 658 658
query35 779 775 666 666
query36 1420 1368 1209 1209
query37 156 103 96 96
query38 1894 1711 1665 1665
query39 941 938 891 891
query39_1 873 899 877 877
query40 254 167 136 136
query41 65 63 61 61
query42 94 93 92 92
query43 329 337 291 291
query44 1498 796 773 773
query45 194 190 179 179
query46 1088 1209 755 755
query47 2353 2367 2221 2221
query48 385 389 302 302
query49 593 427 307 307
query50 1081 422 335 335
query51 10738 10689 10591 10591
query52 86 88 82 82
query53 257 287 204 204
query54 275 237 220 220
query55 76 70 67 67
query56 301 305 303 303
query57 1423 1372 1330 1330
query58 279 271 236 236
query59 1620 1701 1472 1472
query60 319 275 252 252
query61 158 144 150 144
query62 689 643 575 575
query63 241 206 208 206
query64 2839 1036 863 863
query65 4851 4782 4752 4752
query66 1803 502 393 393
query67 28970 29527 29311 29311
query68 3155 1653 1051 1051
query69 463 295 273 273
query70 1090 973 950 950
query71 369 316 310 310
query72 3104 2696 2375 2375
query73 839 791 445 445
query74 5131 4975 4774 4774
query75 2611 2595 2244 2244
query76 2332 1207 805 805
query77 366 379 285 285
query78 12313 12387 11800 11800
query79 1384 1183 776 776
query80 672 547 460 460
query81 458 335 273 273
query82 573 157 123 123
query83 374 323 303 303
query84 280 162 132 132
query85 986 601 505 505
query86 399 315 292 292
query87 1841 1819 1758 1758
query88 3780 2823 2789 2789
query89 467 412 347 347
query90 1848 205 194 194
query91 199 187 161 161
query92 66 61 57 57
query93 1757 1569 989 989
query94 599 380 335 335
query95 814 511 472 472
query96 1093 788 347 347
query97 2715 2678 2583 2583
query98 213 209 200 200
query99 1168 1172 1041 1041
Total cold run time: 265172 ms
Total hot run time: 180566 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3532987575
##########
regression-test/suites/query_p0/ddl/show_trash/test_nereids_trash.groovy:
##########
@@ -20,6 +20,32 @@ suite("show_trash_nereids") {
checkNereidsExecute("""show trash;""")
checkNereidsExecute("""show trash on "127.0.0.1:9050";""")
Review Comment:
This still only checks that the `ON` form executes. The parser bug fixed in this PR also executed successfully because it discarded the backend-specific `ShowTrashCommand(backend)` and fell back to the all-backends command, so this regression would pass with the old broken behavior. Please add an assertion that the `ON` backend is actually preserved or used, for example a parser/unit test that parses `show trash on "host:port"` and checks `ShowTrashCommand.getBackend()`, or an execution test with multiple mocked backends that verifies only the requested backend is queried.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java:
##########
@@ -99,17 +101,43 @@ public static void getTrashInfo(List<Backend> backends, List<List<String>> infos
}
}
- List<String> backendInfo = new ArrayList<>();
- backendInfo.add(String.valueOf(backend.getId()));
- backendInfo.add(NetUtils.getHostPortInAccessibleFormat(backend.getHost(), backend.getHeartbeatPort()));
- if (trashUsedCapacityB != null) {
+ if (diskTrashInfos == null) {
Review Comment:
This `continue` hides the backend whenever `getDiskTrashUsedCapacity()` fails. Before this change, `SHOW TRASH` still emitted the BackendId/Backend row and left the capacity empty when the old `getTrashUsedCapacity()` RPC failed, so operators could see which backend could not report trash. With the expanded per-disk rows, a transient RPC failure now makes the backend disappear from the result entirely, which is misleading for a diagnostic command. Please preserve a fallback row for the backend with the disk-specific columns left empty/unknown instead of skipping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "yx-keith (via GitHub)" <gi...@apache.org>.
yx-keith commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4899109726
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4910145312
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884200762
> cloud p0 case `test_show_charset_auth.groovy` failed
I already fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4567813279
<details>
<summary>TPC-DS: <b>Total hot run time: 172381 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b50517e8508df1429d7b77edddee3a33d14aa717, data reload: false
query5 4361 685 521 521
query6 358 234 208 208
query7 4281 617 324 324
query8 322 236 233 233
query9 8788 4149 4088 4088
query10 448 351 313 313
query11 5771 2560 2226 2226
query12 178 131 127 127
query13 1259 641 447 447
query14 6077 5489 5218 5218
query14_1 4447 4500 4434 4434
query15 211 206 186 186
query16 1017 453 422 422
query17 1121 716 581 581
query18 2520 489 357 357
query19 214 206 164 164
query20 137 142 130 130
query21 219 148 119 119
query22 13708 13609 13352 13352
query23 17316 16435 16222 16222
query23_1 16336 16379 16449 16379
query24 7384 1794 1294 1294
query24_1 1328 1328 1325 1325
query25 559 515 408 408
query26 1311 316 176 176
query27 2760 581 358 358
query28 4457 2027 2036 2027
query29 974 627 492 492
query30 306 246 199 199
query31 1142 1080 963 963
query32 89 76 74 74
query33 528 366 298 298
query34 1197 1196 663 663
query35 772 793 711 711
query36 1395 1419 1228 1228
query37 152 113 90 90
query38 3227 3175 3068 3068
query39 936 923 904 904
query39_1 884 873 877 873
query40 225 151 126 126
query41 68 68 63 63
query42 109 108 110 108
query43 350 346 310 310
query44
query45 214 207 195 195
query46 1096 1233 725 725
query47 2382 2333 2271 2271
query48 378 429 305 305
query49 633 504 401 401
query50 989 352 260 260
query51 4391 4299 4239 4239
query52 107 106 95 95
query53 270 286 207 207
query54 354 298 283 283
query55 106 99 89 89
query56 329 331 322 322
query57 1462 1433 1315 1315
query58 328 295 280 280
query59 1635 1739 1515 1515
query60 347 357 329 329
query61 188 184 188 184
query62 698 655 590 590
query63 254 208 219 208
query64 2491 864 705 705
query65
query66 1736 492 377 377
query67 29742 29794 29620 29620
query68
query69 470 360 311 311
query70 1061 1070 973 973
query71 321 279 282 279
query72 3269 2819 2418 2418
query73 862 778 397 397
query74 5132 5012 4785 4785
query75 2716 2621 2278 2278
query76 2253 1146 798 798
query77 411 446 357 357
query78 12433 12518 11877 11877
query79 1551 1036 789 789
query80 1302 567 468 468
query81 530 279 241 241
query82 1177 164 122 122
query83 357 296 253 253
query84 262 141 113 113
query85 936 588 454 454
query86 459 339 337 337
query87 3413 3368 3247 3247
query88 3680 2748 2760 2748
query89 496 402 338 338
query90 1973 198 185 185
query91 185 169 141 141
query92 86 78 75 75
query93 1490 1460 938 938
query94 751 349 321 321
query95 730 477 357 357
query96 1063 793 324 324
query97 2759 2730 2587 2587
query98 242 229 238 229
query99 1187 1164 1043 1043
Total cold run time: 255764 ms
Total hot run time: 172381 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4566480132
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4919820447
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4920485601
<details>
<summary>TPC-H: <b>Total hot run time: 29896 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 275b29c47c6abaf837b5ba643a1b850875d2f118, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17595 4240 4227 4227
q2 2051 332 203 203
q3 10851 1406 807 807
q4 4766 475 341 341
q5 8443 872 586 586
q6 355 178 140 140
q7 849 833 628 628
q8 10614 1643 1603 1603
q9 5790 4483 4419 4419
q10 6763 1781 1506 1506
q11 508 343 328 328
q12 716 554 440 440
q13 18457 3450 2728 2728
q14 262 258 237 237
q15 q16 789 774 703 703
q17 1032 964 970 964
q18 7021 5893 5637 5637
q19 1193 1286 1090 1090
q20 773 621 550 550
q21 5628 2583 2464 2464
q22 434 358 295 295
Total cold run time: 104890 ms
Total hot run time: 29896 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4565 4421 4392 4392
q2 273 321 217 217
q3 4616 4989 4439 4439
q4 2063 2185 1363 1363
q5 4558 4387 4780 4387
q6 258 203 146 146
q7 1993 1860 1609 1609
q8 2553 2326 2125 2125
q9 7899 7824 7917 7824
q10 4758 4979 4260 4260
q11 635 454 434 434
q12 762 758 554 554
q13 3214 3740 2965 2965
q14 313 324 291 291
q15 q16 725 758 666 666
q17 1431 1409 1325 1325
q18 8157 7278 7039 7039
q19 1131 1046 1157 1046
q20 2240 2204 1939 1939
q21 5329 4627 4534 4534
q22 524 459 413 413
Total cold run time: 57997 ms
Total hot run time: 51968 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4923906341
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 77.39% (1896/2450) |
| Line Coverage | 64.45% (34071/52862) |
| Region Coverage | 64.87% (17536/27032) |
| Branch Coverage | 54.06% (9401/17390) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4926878328
<details>
<summary>TPC-H: <b>Total hot run time: 29625 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17691 4243 4113 4113
q2 2011 322 205 205
q3 10830 1441 809 809
q4 4730 472 339 339
q5 8206 861 569 569
q6 306 177 138 138
q7 816 835 648 648
q8 10594 1573 1524 1524
q9 5808 4394 4417 4394
q10 6804 1803 1528 1528
q11 512 352 319 319
q12 715 551 445 445
q13 18091 3320 2770 2770
q14 272 274 253 253
q15 q16 784 786 714 714
q17 967 1044 944 944
q18 6920 5780 5532 5532
q19 1641 1361 1049 1049
q20 789 656 590 590
q21 5806 2701 2447 2447
q22 426 356 295 295
Total cold run time: 104719 ms
Total hot run time: 29625 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4617 4436 4441 4436
q2 295 320 219 219
q3 4546 4902 4406 4406
q4 2089 2153 1394 1394
q5 4521 4285 4627 4285
q6 261 198 150 150
q7 2121 1808 1650 1650
q8 2491 2158 2233 2158
q9 7950 7849 7857 7849
q10 4778 4861 4315 4315
q11 599 419 385 385
q12 752 758 584 584
q13 3229 3666 3063 3063
q14 313 316 268 268
q15 q16 722 750 675 675
q17 1375 1309 1336 1309
q18 8078 7199 6841 6841
q19 1127 1076 1069 1069
q20 2211 2201 1939 1939
q21 5285 4633 4453 4453
q22 539 466 412 412
Total cold run time: 57899 ms
Total hot run time: 51860 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4932079414
# BE Regression && UT Coverage Report
Increment line coverage `80.00% (12/15)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 74.82% (29982/40072) |
| Line Coverage | 58.91% (329055/558547) |
| Region Coverage | 55.84% (276854/495831) |
| Branch Coverage | 57.06% (121752/213368) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3524027856
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTrashCommand.java:
##########
@@ -65,7 +65,7 @@ public String getBackend() {
public ShowResultSetMetaData getMetaData() {
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();
for (String title : TrashProcDir.TITLE_NAMES) {
- builder.addColumn(new Column(title, ScalarType.createVarchar(30)));
+ builder.addColumn(new Column(title, ScalarType.createVarchar(60)));
Review Comment:
Thanks, now I already fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884201018
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884564617
<details>
<summary>TPC-DS: <b>Total hot run time: 173991 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 90ccbf08f63b932fb3e782b927e234b3a604d206, data reload: false
query5 4332 640 512 512
query6 474 230 207 207
query7 4966 606 356 356
query8 344 189 173 173
query9 8785 4189 4155 4155
query10 442 356 306 306
query11 5876 2353 2136 2136
query12 155 109 105 105
query13 1294 595 445 445
query14 6282 5375 5048 5048
query14_1 4401 4344 4328 4328
query15 212 208 181 181
query16 1048 476 441 441
query17 1133 736 611 611
query18 2455 484 353 353
query19 214 196 156 156
query20 116 110 108 108
query21 239 163 136 136
query22 13693 13630 13516 13516
query23 17420 16713 16156 16156
query23_1 16295 16324 16373 16324
query24 7481 1813 1319 1319
query24_1 1357 1296 1361 1296
query25 560 448 358 358
query26 1313 341 205 205
query27 2605 572 389 389
query28 4451 2008 2031 2008
query29 1070 606 487 487
query30 336 263 226 226
query31 1109 1090 981 981
query32 119 58 62 58
query33 526 319 260 260
query34 1183 1129 632 632
query35 759 789 667 667
query36 1414 1411 1216 1216
query37 157 109 95 95
query38 1877 1704 1635 1635
query39 920 933 926 926
query39_1 905 893 866 866
query40 240 156 146 146
query41 66 62 62 62
query42 93 91 90 90
query43 326 324 277 277
query44 1488 786 777 777
query45 198 179 181 179
query46 1151 1202 727 727
query47 2375 2327 2278 2278
query48 391 413 296 296
query49 577 426 322 322
query50 1061 430 339 339
query51 4418 4452 4294 4294
query52 86 85 75 75
query53 267 281 204 204
query54 277 231 220 220
query55 76 71 67 67
query56 286 289 266 266
query57 1470 1394 1327 1327
query58 288 246 244 244
query59 1617 1651 1448 1448
query60 301 266 248 248
query61 152 151 151 151
query62 695 641 596 596
query63 241 204 219 204
query64 2565 772 612 612
query65 4820 4804 4780 4780
query66 1849 513 383 383
query67 29522 29469 29374 29374
query68 3145 1563 895 895
query69 412 305 263 263
query70 1063 996 977 977
query71 348 320 305 305
query72 2970 2628 2316 2316
query73 849 752 415 415
query74 5128 4965 4756 4756
query75 2625 2587 2235 2235
query76 2337 1212 833 833
query77 354 382 277 277
query78 12488 12524 11916 11916
query79 1204 1156 754 754
query80 595 540 469 469
query81 452 324 288 288
query82 238 158 120 120
query83 308 329 293 293
query84 278 171 133 133
query85 880 609 518 518
query86 338 297 270 270
query87 1840 1813 1741 1741
query88 3738 2828 2803 2803
query89 443 416 353 353
query90 2174 199 192 192
query91 202 190 160 160
query92 64 63 59 59
query93 1550 1527 987 987
query94 553 356 312 312
query95 801 613 475 475
query96 1104 813 351 351
query97 2705 2673 2572 2572
query98 213 205 206 205
query99 1179 1155 1037 1037
Total cold run time: 258192 ms
Total hot run time: 173991 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4926983631
<details>
<summary>TPC-DS: <b>Total hot run time: 180777 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58, data reload: false
query5 4330 647 510 510
query6 451 222 193 193
query7 4841 595 362 362
query8 351 205 177 177
query9 8749 4099 4089 4089
query10 506 357 285 285
query11 5797 2418 2150 2150
query12 161 103 103 103
query13 1281 641 439 439
query14 6310 5341 5002 5002
query14_1 4344 4326 4316 4316
query15 215 212 187 187
query16 1042 491 481 481
query17 1146 764 592 592
query18 2736 483 358 358
query19 215 203 153 153
query20 112 112 109 109
query21 233 161 138 138
query22 13644 13562 13390 13390
query23 17505 16565 16300 16300
query23_1 16402 16253 16287 16253
query24 7520 1796 1303 1303
query24_1 1354 1330 1322 1322
query25 565 495 399 399
query26 1353 346 203 203
query27 2563 589 385 385
query28 4437 2052 2024 2024
query29 1077 646 503 503
query30 343 268 227 227
query31 1136 1099 988 988
query32 105 65 63 63
query33 536 340 270 270
query34 1191 1137 614 614
query35 783 787 704 704
query36 1399 1356 1177 1177
query37 154 107 91 91
query38 1892 1702 1673 1673
query39 928 910 902 902
query39_1 897 874 878 874
query40 251 165 143 143
query41 66 65 63 63
query42 101 92 92 92
query43 320 331 284 284
query44 1467 770 769 769
query45 220 190 183 183
query46 1110 1184 753 753
query47 2341 2335 2263 2263
query48 407 387 299 299
query49 580 421 325 325
query50 1031 425 335 335
query51 10992 10866 10827 10827
query52 84 86 72 72
query53 258 280 202 202
query54 278 237 236 236
query55 75 73 66 66
query56 296 288 292 288
query57 1438 1397 1323 1323
query58 279 261 262 261
query59 1581 1674 1445 1445
query60 317 275 255 255
query61 155 151 153 151
query62 703 660 591 591
query63 233 207 204 204
query64 2807 1052 875 875
query65 4893 4831 4783 4783
query66 1775 512 390 390
query67 29951 29633 29004 29004
query68 3479 1501 1034 1034
query69 420 315 268 268
query70 1081 1002 991 991
query71 352 337 325 325
query72 3167 2724 2433 2433
query73 792 787 458 458
query74 5147 4943 4757 4757
query75 2626 2602 2228 2228
query76 2312 1201 782 782
query77 359 386 292 292
query78 12388 12336 11774 11774
query79 1418 1190 769 769
query80 1302 539 470 470
query81 521 335 297 297
query82 584 156 130 130
query83 362 322 294 294
query84 280 160 128 128
query85 958 594 514 514
query86 431 309 288 288
query87 1838 1847 1776 1776
query88 3739 2799 2754 2754
query89 461 411 358 358
query90 1883 201 200 200
query91 203 190 158 158
query92 65 62 54 54
query93 1808 1569 1019 1019
query94 729 347 334 334
query95 779 518 561 518
query96 1049 754 357 357
query97 2688 2719 2563 2563
query98 222 205 207 205
query99 1165 1175 1032 1032
Total cold run time: 267706 ms
Total hot run time: 180777 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4927026562
<details>
<summary>ClickBench: <b>Total hot run time: 25.56 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58, data reload: false
query1 0.01 0.00 0.00
query2 0.14 0.08 0.07
query3 0.36 0.23 0.24
query4 1.61 0.24 0.24
query5 0.33 0.31 0.30
query6 1.16 0.67 0.67
query7 0.04 0.01 0.00
query8 0.09 0.06 0.07
query9 0.53 0.39 0.39
query10 0.60 0.58 0.58
query11 0.31 0.20 0.18
query12 0.31 0.19 0.20
query13 0.54 0.53 0.54
query14 0.93 0.92 0.92
query15 0.68 0.60 0.59
query16 0.38 0.38 0.38
query17 1.00 1.00 1.00
query18 0.30 0.29 0.30
query19 1.91 1.81 1.80
query20 0.03 0.02 0.01
query21 15.40 0.38 0.32
query22 4.96 0.13 0.14
query23 15.76 0.51 0.30
query24 2.42 0.62 0.43
query25 0.15 0.11 0.10
query26 0.75 0.27 0.22
query27 0.11 0.10 0.11
query28 3.39 0.95 0.55
query29 12.49 4.25 3.27
query30 0.38 0.27 0.25
query31 2.77 0.63 0.32
query32 3.22 0.59 0.46
query33 2.98 2.91 2.91
query34 15.89 4.08 3.39
query35 3.32 3.31 3.28
query36 0.67 0.54 0.51
query37 0.12 0.10 0.09
query38 0.09 0.06 0.06
query39 0.07 0.07 0.06
query40 0.21 0.19 0.17
query41 0.13 0.08 0.08
query42 0.09 0.07 0.06
query43 0.08 0.07 0.07
Total cold run time: 96.71 s
Total hot run time: 25.56 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4925239985
# FE Regression Coverage Report
Increment line coverage ` 42.86% (57/133)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_7eba89ef8fe9f4816eb4bae1e47f6f7ac6280b58_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4940228394
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884895245
# FE Regression Coverage Report
Increment line coverage ` 75.00% (42/56)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_90ccbf08f63b932fb3e782b927e234b3a604d206_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_90ccbf08f63b932fb3e782b927e234b3a604d206_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884527710
<details>
<summary>TPC-H: <b>Total hot run time: 29587 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 90ccbf08f63b932fb3e782b927e234b3a604d206, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17680 4070 4032 4032
q2 2007 333 202 202
q3 10925 1473 824 824
q4 4799 478 336 336
q5 8445 838 567 567
q6 346 170 138 138
q7 847 835 632 632
q8 10670 1566 1495 1495
q9 5845 4477 4422 4422
q10 6841 1800 1514 1514
q11 509 346 323 323
q12 709 558 438 438
q13 18092 3425 2691 2691
q14 267 261 241 241
q15 q16 795 789 719 719
q17 1009 1014 905 905
q18 6820 5769 5537 5537
q19 1161 1242 1087 1087
q20 733 636 536 536
q21 5502 2726 2634 2634
q22 442 363 314 314
Total cold run time: 104444 ms
Total hot run time: 29587 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4398 4337 4304 4304
q2 297 319 212 212
q3 4663 4969 4420 4420
q4 2119 2168 1397 1397
q5 4503 4352 4409 4352
q6 360 214 149 149
q7 2083 1788 1647 1647
q8 2530 2152 2176 2152
q9 7838 7817 7893 7817
q10 4764 4710 4346 4346
q11 577 406 380 380
q12 761 755 540 540
q13 3235 3586 3017 3017
q14 299 292 272 272
q15 q16 719 742 652 652
q17 1379 1389 1369 1369
q18 7969 7333 6811 6811
q19 1153 1124 1131 1124
q20 2237 2211 1957 1957
q21 5373 4598 4444 4444
q22 536 455 433 433
Total cold run time: 57793 ms
Total hot run time: 51795 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4884574331
<details>
<summary>ClickBench: <b>Total hot run time: 25.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 90ccbf08f63b932fb3e782b927e234b3a604d206, data reload: false
query1 0.01 0.00 0.01
query2 0.14 0.09 0.08
query3 0.38 0.25 0.25
query4 1.61 0.25 0.26
query5 0.33 0.32 0.32
query6 1.16 0.68 0.67
query7 0.03 0.01 0.00
query8 0.09 0.07 0.07
query9 0.52 0.38 0.39
query10 0.58 0.58 0.58
query11 0.30 0.18 0.17
query12 0.31 0.19 0.18
query13 0.53 0.54 0.52
query14 0.93 0.92 0.93
query15 0.68 0.58 0.59
query16 0.39 0.40 0.38
query17 0.99 0.99 1.02
query18 0.31 0.30 0.29
query19 1.90 1.77 1.77
query20 0.02 0.02 0.01
query21 15.40 0.37 0.32
query22 4.91 0.14 0.13
query23 15.84 0.53 0.31
query24 2.43 0.63 0.45
query25 0.14 0.11 0.10
query26 0.74 0.28 0.22
query27 0.10 0.09 0.09
query28 3.37 0.94 0.53
query29 12.45 4.41 3.52
query30 0.39 0.30 0.26
query31 2.79 0.62 0.35
query32 3.24 0.61 0.47
query33 2.92 2.99 3.03
query34 15.75 4.11 3.36
query35 3.26 3.25 3.32
query36 0.63 0.52 0.52
query37 0.12 0.10 0.09
query38 0.08 0.08 0.06
query39 0.08 0.06 0.05
query40 0.19 0.18 0.17
query41 0.12 0.08 0.07
query42 0.09 0.06 0.07
query43 0.08 0.07 0.07
Total cold run time: 96.33 s
Total hot run time: 25.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "heguanhui (via GitHub)" <gi...@apache.org>.
heguanhui commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4898838257
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900479040
<details>
<summary>TPC-H: <b>Total hot run time: 29656 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41fc280859aa4441500d68d0f05ac7fc38127931, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17580 4077 4075 4075
q2 2062 324 223 223
q3 10216 1422 830 830
q4 4686 471 336 336
q5 7545 849 585 585
q6 186 175 141 141
q7 777 837 616 616
q8 9336 1502 1602 1502
q9 5822 4438 4427 4427
q10 6811 1831 1555 1555
q11 511 352 319 319
q12 745 544 425 425
q13 18209 3420 2795 2795
q14 276 268 247 247
q15 q16 791 773 710 710
q17 969 926 1004 926
q18 7670 5766 5606 5606
q19 1165 1261 1017 1017
q20 793 668 572 572
q21 5555 2520 2441 2441
q22 432 358 308 308
Total cold run time: 102137 ms
Total hot run time: 29656 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4338 4249 4266 4249
q2 276 314 216 216
q3 4532 4970 4414 4414
q4 2036 2163 1366 1366
q5 4441 4316 4332 4316
q6 231 172 131 131
q7 1750 1978 1757 1757
q8 2555 2174 2219 2174
q9 8052 8199 7782 7782
q10 4771 4728 4241 4241
q11 557 453 382 382
q12 738 782 561 561
q13 3286 3511 3043 3043
q14 294 300 282 282
q15 q16 711 743 667 667
q17 1352 1337 1335 1335
q18 8049 7454 7280 7280
q19 1146 1128 1130 1128
q20 2307 2231 1938 1938
q21 5234 4604 4412 4412
q22 527 467 408 408
Total cold run time: 57183 ms
Total hot run time: 52082 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900541320
<details>
<summary>TPC-DS: <b>Total hot run time: 181641 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 41fc280859aa4441500d68d0f05ac7fc38127931, data reload: false
query5 4321 633 518 518
query6 498 237 199 199
query7 4840 612 334 334
query8 353 193 188 188
query9 8770 4095 4097 4095
query10 479 360 294 294
query11 5919 2366 2112 2112
query12 175 98 100 98
query13 1253 598 429 429
query14 6263 5316 4966 4966
query14_1 4327 4305 4336 4305
query15 220 203 178 178
query16 1023 505 451 451
query17 929 713 587 587
query18 2425 457 334 334
query19 205 186 149 149
query20 111 105 109 105
query21 246 153 133 133
query22 13646 13614 13386 13386
query23 17367 16414 16216 16216
query23_1 16352 16257 16298 16257
query24 7583 1806 1333 1333
query24_1 1356 1311 1324 1311
query25 579 470 390 390
query26 1355 369 214 214
query27 2564 586 364 364
query28 4522 2068 2038 2038
query29 1080 627 518 518
query30 335 264 224 224
query31 1109 1098 981 981
query32 112 64 66 64
query33 526 327 262 262
query34 1177 1113 671 671
query35 792 790 676 676
query36 1383 1408 1247 1247
query37 157 113 95 95
query38 1916 1703 1663 1663
query39 928 934 903 903
query39_1 883 873 894 873
query40 260 164 150 150
query41 80 70 69 69
query42 96 95 98 95
query43 333 335 293 293
query44 1421 780 791 780
query45 211 205 185 185
query46 1042 1192 760 760
query47 2352 2311 2202 2202
query48 405 424 309 309
query49 601 433 330 330
query50 1053 417 348 348
query51 10885 10836 10876 10836
query52 86 87 77 77
query53 260 287 213 213
query54 300 250 228 228
query55 78 74 74 74
query56 319 306 288 288
query57 1443 1387 1331 1331
query58 299 256 266 256
query59 1589 1654 1467 1467
query60 324 319 259 259
query61 156 152 149 149
query62 686 647 593 593
query63 254 212 207 207
query64 2544 745 600 600
query65 4875 4811 4794 4794
query66 1828 509 384 384
query67 29704 29594 29355 29355
query68 3290 1499 1020 1020
query69 405 308 274 274
query70 1096 978 1005 978
query71 365 323 312 312
query72 2923 2681 2367 2367
query73 824 816 433 433
query74 5135 4983 4757 4757
query75 2617 2572 2212 2212
query76 2411 1183 781 781
query77 361 392 291 291
query78 12362 12300 11725 11725
query79 1385 1172 794 794
query80 947 550 481 481
query81 526 324 278 278
query82 627 157 121 121
query83 414 317 294 294
query84 328 160 130 130
query85 987 618 553 553
query86 417 296 280 280
query87 1848 1819 1751 1751
query88 3691 2799 2821 2799
query89 456 421 350 350
query90 1802 202 210 202
query91 199 192 159 159
query92 63 58 59 58
query93 1595 1508 1001 1001
query94 628 354 323 323
query95 781 579 490 490
query96 1107 807 341 341
query97 2655 2698 2522 2522
query98 219 207 200 200
query99 1169 1163 1020 1020
Total cold run time: 265625 ms
Total hot run time: 181641 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4900568407
<details>
<summary>ClickBench: <b>Total hot run time: 25.66 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41fc280859aa4441500d68d0f05ac7fc38127931, data reload: false
query1 0.00 0.00 0.01
query2 0.15 0.08 0.08
query3 0.40 0.24 0.24
query4 1.62 0.25 0.24
query5 0.34 0.32 0.31
query6 1.16 0.67 0.67
query7 0.04 0.01 0.00
query8 0.09 0.07 0.08
query9 0.51 0.38 0.39
query10 0.61 0.59 0.59
query11 0.32 0.18 0.17
query12 0.32 0.19 0.19
query13 0.52 0.54 0.52
query14 0.94 0.92 0.92
query15 0.68 0.59 0.59
query16 0.39 0.40 0.39
query17 1.03 1.01 1.01
query18 0.32 0.30 0.31
query19 1.92 1.83 1.85
query20 0.02 0.02 0.01
query21 15.46 0.37 0.31
query22 4.86 0.14 0.13
query23 15.87 0.48 0.30
query24 2.40 0.60 0.43
query25 0.16 0.11 0.09
query26 0.75 0.27 0.22
query27 0.10 0.10 0.10
query28 3.41 0.91 0.51
query29 12.47 4.10 3.27
query30 0.37 0.28 0.26
query31 2.76 0.60 0.34
query32 3.23 0.60 0.48
query33 2.91 3.02 2.94
query34 15.78 4.09 3.35
query35 3.30 3.32 3.31
query36 0.65 0.53 0.51
query37 0.13 0.09 0.09
query38 0.09 0.07 0.07
query39 0.08 0.07 0.06
query40 0.20 0.19 0.17
query41 0.13 0.09 0.08
query42 0.09 0.06 0.06
query43 0.07 0.07 0.07
Total cold run time: 96.65 s
Total hot run time: 25.66 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe)(be) Add disk-level metrics to SHOW TRASH command [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63864:
URL: https://github.com/apache/doris/pull/63864#issuecomment-4568679307
# BE Regression && UT Coverage Report
Increment line coverage `40.00% (6/15)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63864_b50517e8508df1429d7b77edddee3a33d14aa717_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63864_b50517e8508df1429d7b77edddee3a33d14aa717_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.85% (28107/38058) |
| Line Coverage | 57.78% (305335/528462) |
| Region Coverage | 54.93% (255561/465272) |
| Branch Coverage | 56.46% (110460/195647) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org