You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/01/12 09:48:08 UTC

Review Request 55448: Implemented TODOs to use common ID validation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55448/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and James Peach.


Repository: mesos


Description
-------

Implemented TODOs to use common ID validation.


Diffs
-----

  src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
  src/slave/validation.cpp abd9b12483a9a62a40f6b6e89c5d866c9f8881af 

Diff: https://reviews.apache.org/r/55448/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 55448: Implemented TODOs to use common ID validation.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55448/#review161574
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Jan. 12, 2017, 9:48 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55448/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 9:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented TODOs to use common ID validation.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f 
>   src/slave/validation.cpp abd9b12483a9a62a40f6b6e89c5d866c9f8881af 
> 
> Diff: https://reviews.apache.org/r/55448/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>