[GitHub] [couchdb] nickva commented on a change in pull request #2458: Fix fabric worker failures for partition requests

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #2458: Fix fabric worker failures for partition requests
URL: https://github.com/apache/couchdb/pull/2458#discussion_r367173914
 
 

 ##########
 File path: src/dreyfus/src/dreyfus_util.erl
 ##########
 @@ -59,6 +59,15 @@ use_ushards(#index_query_args{stable=true}) ->
 use_ushards(#index_query_args{}) ->
     false.
 
+
+get_ring_opts(#index_query_args{partition = nil}, _Shards) ->
+    [];
+get_ring_opts(#index_query_args{}, Shards) ->
+    Shards1 = lists:map(fun(#shard{} = S) ->
+        S#shard{ref = undefined}
 
 Review comment:
   Since we want to match those shards exactly we set the worker references to `undefined`. 
   
   In `fabric_db_partition` we get them directly from mem:shards(...) so they won't have references set. In case of dreyfus in one case we get the shards from the workers fabric_dict which have references so we clear them out in `get_ring_opts`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services